Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Feedback #35

Open
2 of 3 tasks
anilhelvaci opened this issue Jun 10, 2024 · 1 comment
Open
2 of 3 tasks

PR Feedback #35

anilhelvaci opened this issue Jun 10, 2024 · 1 comment

Comments

@anilhelvaci
Copy link
Collaborator

anilhelvaci commented Jun 10, 2024 •
edited
Loading

Context

See Agoric#8994

What's left?
anilhelvaci added a commit that referenced this issue Jun 10, 2024
@anilhelvaci
fixup(liquidationVisibility): remove the unused prefix
b477054 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 10, 2024
@anilhelvaci
fixup(liquidationVisibility): destructure helper facet
ccd9f38 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 10, 2024
@anilhelvaci
fixup(liquidationVisibility): drop references to `LiquidationVisibili…
238b6f0 
…ty` in core-eval

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 10, 2024
@anilhelvaci
fixup(liquidationVisibility): add startTime field to `auctionResult…
90a5024 
…s` and update tests accordingly

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 10, 2024
@anilhelvaci
fixup(liquidationVisibility): remove leftover comment and fix typo.
9e0a91a 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 13, 2024
@anilhelvaci
fixup(liquidationVisibility): implement checkWritersPresent and rem…
4106a62 
…ove `writeLiqVisibility`

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 13, 2024
@anilhelvaci
fixup(liquidationVisibility): Directly invoking methods on `liquidati…
984f55b 
…onVisibilityWriters` resulted with below changes;

* Use `Promise.all` instead of `allValuesSettled`
* Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore
* Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans

Refs: #35
@anilhelvaci
Copy link
Collaborator Author

Important for commit 984f55b

As plan and vaultsInPlan are assigned implicitly tsc complained with TS2322 error. The assignment of plan and vaultsInPlan is tied to helper.planProceedsDistribution working without any errors and in the case of any error, the error is handled in the catch statement.

With this commit, we've introduced a new message in postAuctionRecorderKit and auctionResultsRecorderKit to indicate if plan or vaultsInPlan are not assigned properly for some reason, we print { error: 'Error distributing proceeds' }. Since there's no way I could find to produce this case in the tests, I had to proceed with no explicit tests. As all the other tests are passing, I believe it might be sufficient to leave it like this.

anilhelvaci added a commit that referenced this issue Jun 13, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove compatability tests and their re…
c8b8618 
…lated artifacts.

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 14, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove unnecessary script `build:upgrad…
e0ae6c0 
…e-vaults-proposal`

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): remove the unused prefix
30eba21 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): destructure helper facet
1ce09ca 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): drop references to `LiquidationVisibili…
49a3e10 
…ty` in core-eval

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): add startTime field to `auctionResult…
bc7028e 
…s` and update tests accordingly

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): remove leftover comment and fix typo.
52d282b 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): implement checkWritersPresent and rem…
c82cc91 
…ove `writeLiqVisibility`

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): Directly invoking methods on `liquidati…
0c71957 
…onVisibilityWriters` resulted with below changes;

* Use `Promise.all` instead of `allValuesSettled`
* Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore
* Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove compatability tests and their re…
bc3793f 
…lated artifacts.

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove unnecessary script `build:upgrad…
fe6baee 
…e-vaults-proposal`

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 17, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove allValuesSetteled()
01fd405 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): remove the unused prefix
6987215 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): destructure helper facet
4df4461 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): drop references to `LiquidationVisibili…
bf1710a 
…ty` in core-eval

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): add startTime field to `auctionResult…
cf11482 
…s` and update tests accordingly

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): remove leftover comment and fix typo.
d3e14f2 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): implement checkWritersPresent and rem…
7f4a8e8 
…ove `writeLiqVisibility`

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): Directly invoking methods on `liquidati…
5269908 
…onVisibilityWriters` resulted with below changes;

* Use `Promise.all` instead of `allValuesSettled`
* Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore
* Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove compatability tests and their re…
909500f 
…lated artifacts.

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove unnecessary script `build:upgrad…
525f8f4 
…e-vaults-proposal`

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 18, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove allValuesSetteled()
cc1127e 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
fixup(liquidationVisibility): Rebase fixes - type and lint
c818fb4 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
fixup(liquidationVisibility): Rebase fixes - type and lint
45e6f6e 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
chore(liquidationVisibility): Add new data fields
ce09411 
TODO: Update bootstrap tests as well

Refs: #35 #36
anilhelvaci pushed a commit that referenced this issue Jun 21, 2024
@Jorge-Lopes @anilhelvaci
chore(liquidationVisibility): update LiquidationOutcome and expected …
2d3f580 
…auctionResult with new data fields

Ref: #35 and #36
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
chore(liquidationVisibility): Add a3p proposal
37c45b5 
Refs: #35
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
chore(liquidationVisibility): Remove unnecessary change from liquidat…
2ca4a8a 
…ion.ts

Refs: #35
anilhelvaci added a commit that referenced this issue Jun 25, 2024
@anilhelvaci
chore(liquidationVisibility): builders lint fix
03a8a40 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): remove the unused prefix
4508c86 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): destructure helper facet
c45b568 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): drop references to `LiquidationVisibili…
b5bd27a 
…ty` in core-eval

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): add startTime field to `auctionResult…
298aa06 
…s` and update tests accordingly

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): remove leftover comment and fix typo.
3ae097a 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): implement checkWritersPresent and rem…
d835bd8 
…ove `writeLiqVisibility`

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): Directly invoking methods on `liquidati…
6188fc8 
…onVisibilityWriters` resulted with below changes;

* Use `Promise.all` instead of `allValuesSettled`
* Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore
* Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove compatability tests and their re…
7c9d989 
…lated artifacts.

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): Remove allValuesSetteled()
3699de9 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): Rebase fixes
95f8c8e 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): Rebase fixes - type and lint
e42c203 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fixup(liquidationVisibility): Rebase fixes - type and lint
2093f0a 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
chore(liquidationVisibility): Add new data fields
0fa050f 
TODO: Update bootstrap tests as well

Refs: #35 #36
anilhelvaci pushed a commit that referenced this issue Jul 15, 2024
@Jorge-Lopes @anilhelvaci
chore(liquidationVisibility): update LiquidationOutcome and expected …
c013902 
…auctionResult with new data fields

Ref: #35 and #36
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
chore(liquidationVisibility): Add a3p proposal
38687dc 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
chore(liquidationVisibility): Remove unnecessary change from liquidat…
6931290 
…ion.ts

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
chore(liquidationVisibility): builders lint fix
09f3452 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fix(liquidationVisibility): rebase fix
84c896c 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fix(liquidationVisibility): lint fixes
f3a508c 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fix(liquidationVisibility): lint fixes
a31107d 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
fix(liquidationVisibility): remove Work Backlog
66108ca 
Refs: #35
anilhelvaci added a commit that referenced this issue Jul 16, 2024
@anilhelvaci
fix(liquidationVisibility): rename test-liquidation-visibility.js t…
8483c67 
…o `eval-liquidation-visibility.js`

Refs: #35
anilhelvaci added a commit that referenced this issue Jul 16, 2024
@anilhelvaci
fix(liquidationVisibility): start using submission for builds
bd8a071 
Refs: #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anilhelvaci