Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoint to edit the config of a single module #271

Open
a-waider opened this issue Nov 15, 2021 · 5 comments
Open

API endpoint to edit the config of a single module #271

a-waider opened this issue Nov 15, 2021 · 5 comments

Comments

@a-waider
Copy link

Description

Hey there,

did you guys ever think about adding an endpoint to edit the config of a single module? Would be a really nice feature when configuring the magic mirror for a specific module.

Changelog

Need to add another endpoint to api.js and some logic to node_helper.js.

Requirements

This shouldn't be that difficult to implement. More important this needs a general decision if such an endpoint is justified.

Additional info

No response

@ezeholz
Copy link
Collaborator

ezeholz commented Nov 15, 2021

It's a great addition, but I think that first we'll need to solve #241
I can add it, but as long as that issue still active, MM will require a full reload.

And also having "Edit config.js" in Menu seems to solve the issue for most people.

@a-waider
Copy link
Author

Nice to hear this positive response from you. I'm definitely willing to help you implementing this feature and verifying if this meets my initial issue post.

In my opinion reloading the complete page isn't a big problem, cause in my use case the page reloads pretty quick.

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

@github-actions github-actions bot added the stale label Dec 6, 2021
@ezeholz
Copy link
Collaborator

ezeholz commented Dec 6, 2021

I totally forgot about this issue.
For now, I'll add it as stated before, it'll act the same way as modifing the full config file, and it'll restart the whole browser.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

@github-actions github-actions bot added stale and removed stale labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants