Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event tracing fails because of missing modules open #81

Open
credmond opened this issue Feb 5, 2024 · 1 comment
Open

Event tracing fails because of missing modules open #81

credmond opened this issue Feb 5, 2024 · 1 comment

Comments

@credmond
Copy link

credmond commented Feb 5, 2024

Caused by: java.lang.IllegalAccessException: module javafx.base cannot access class org.scenicview.view.tabs.EventLogTab$ScenicViewEvent (in module org.scenicview.scenicview) because module org.scenicview.scenicview does not open org.scenicview.view.tabs to javafx.base
        at [email protected]/com.sun.javafx.property.MethodHelper.invoke(Unknown Source)
        ... 57 more

I think ScenicView is missing other "opens" too for itself (org.scenicview.view.xxx) -- I recall some stacktraces in the past.

For a standalone UI like this, I don't really see the point in worrying about individual opens -- just use a global open module, especially since there doesn't appear to be any tests to find these types of issues.

@credmond
Copy link
Author

credmond commented Feb 5, 2024

Fixed in this PR: #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant