Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky doesn't work #64

Closed
VirxEC opened this issue Nov 13, 2023 · 4 comments
Closed

Sky doesn't work #64

VirxEC opened this issue Nov 13, 2023 · 4 comments

Comments

@VirxEC
Copy link
Contributor

VirxEC commented Nov 13, 2023

When I updated to the new 0.8 version, I get the error ERROR bevy_asset::server: path not found: bevy_atmosphere/shaders/skybox.wgsl Which is weird because this plugin used to work when I was testing it earlier on the PR fork and I dropped a comment saying that it worked fine.

@Shatur
Copy link
Collaborator

Shatur commented Nov 13, 2023

Interesting, looks like it works locally (examples still work!), but doesn't work if it's a separate crate. @sphw maybe you know what could cause it?

@sphw
Copy link
Contributor

sphw commented Nov 14, 2023

My best guess is this is something to do with a bug with embedded_asset and publish crates / libraries. Not exactly sure what. IMO given all the strangeness and bugs with embedded_asset it might make sense to revert the commit that makes that change from my PR, and wait until it stabilizes further.

@Shatur
Copy link
Collaborator

Shatur commented Nov 14, 2023

Agree, could you please open a PR that reverts to the previous approach?

@Shatur
Copy link
Collaborator

Shatur commented Nov 14, 2023

Fixed by #65.

@Shatur Shatur closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants