Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus issue list for "rainbow editions" Oct 2024 #1962

Open
chuck-h opened this issue Nov 9, 2024 · 0 comments
Open

Omnibus issue list for "rainbow editions" Oct 2024 #1962

chuck-h opened this issue Nov 9, 2024 · 0 comments

Comments

@chuck-h
Copy link
Collaborator

chuck-h commented Nov 9, 2024

After a burst of work in 3Q24 the rainbow_apk and rainbow_upgrade branches were left in a "demo" or "proof-of-concept" state with several new features.

This issue is an attempt to capture some of the know shortcomings of that sprint before memory fades

Send Expert Screen - account search
In contrast to the Send Basic screen, here the account name text is simply checked for existence on the blockchain. The multi-pronged lookup would be better. Q: is there enough screen layout space?
Account lookup should trim trailing space (or more generally, sanitize) before checking

Send Abroad screen
Available balance fiat equivalent does not work (dummy value is hard coded for demo); but fiat equiv does work in "proxy send". -- perhaps revise SwapEnterDataScreen to use Form widget containing both amount widgets, and cleaning up the GlobalKey-pushText action

Proxy Send confirmation screen
Should show both accounts (only shows recipient)

Send Expert Screen - signers list popup
Should show multisig weight for each signer
Should show threshold (and provide UI to change?)

Add New Authorization screen
Account name is not validated. Should use account search UI
Should be able to set multisig weight (use case: temporarily authorize specific single signer for a 2/3 msig)

Send Abroad fiat/token switch
does not update exchanged token balance

Fiat Exchange rate
Is it necessary to do all those ugly calls to rate routine?
Future: access valuation hook in Rainbow token contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant