From 264da4b27645826d416605ca7ed35a6e5a797c54 Mon Sep 17 00:00:00 2001
From: fox <83943819+fewkz@users.noreply.github.com>
Date: Sat, 24 Sep 2022 06:48:47 -0400
Subject: [PATCH] BasePart type improvements (#150)

---
 scripts/dumpRobloxTypes.py | 16 ++++++++++++++++
 scripts/globalTypes.d.lua  | 12 ++++++------
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/scripts/dumpRobloxTypes.py b/scripts/dumpRobloxTypes.py
index 16a9a887..5b4f1709 100644
--- a/scripts/dumpRobloxTypes.py
+++ b/scripts/dumpRobloxTypes.py
@@ -144,6 +144,14 @@
     ],
     "Player": ["Character"],
     "InstanceAdornment": ["Adornee"],
+    "BasePart": [
+        "GetConnectedParts",
+        "GetJoints",
+        "GetNetworkOwner",
+        "GetTouchingParts",
+        "SubtractAsync",
+        "UnionAsync",
+    ]
 }
 
 # Extra members to add in to classes, commonly used to add in metamethods, and add corrections
@@ -292,6 +300,14 @@
     ],
     "Player": ["Character: Model?"],
     "InstanceAdornment": ["Adornee: Instance?"],
+    "BasePart": [
+        "function GetConnectedParts(self, recursive: boolean?): { BasePart }",
+        "function GetJoints(self): { BasePart }",
+        "function GetNetworkOwner(self): Player?",
+        "function GetTouchingParts(self): { BasePart }",
+        "function SubtractAsync(self, parts: { BasePart }, collisionfidelity: EnumCollisionFidelity?, renderFidelity: EnumRenderFidelity?): UnionOperation",
+        "function UnionAsync(self, parts: { BasePart }, collisionfidelity: EnumCollisionFidelity?, renderFidelity: EnumRenderFidelity?): UnionOperation",
+    ]
 }
 
 # Hardcoded types
diff --git a/scripts/globalTypes.d.lua b/scripts/globalTypes.d.lua
index 6d25d9e6..178e53de 100644
--- a/scripts/globalTypes.d.lua
+++ b/scripts/globalTypes.d.lua
@@ -7345,23 +7345,23 @@ declare class BasePart extends PVInstance
 	function BreakJoints(self): nil
 	function CanCollideWith(self, part: BasePart): boolean
 	function CanSetNetworkOwnership(self): (boolean, string)
-	function GetConnectedParts(self, recursive: boolean?): { Instance }
-	function GetJoints(self): { Instance }
 	function GetMass(self): number
-	function GetNetworkOwner(self): Player
 	function GetNetworkOwnershipAuto(self): boolean
 	function GetRootPart(self): BasePart
-	function GetTouchingParts(self): { Instance }
 	function GetVelocityAtPosition(self, position: Vector3): Vector3
 	function IsGrounded(self): boolean
 	function MakeJoints(self): nil
 	function Resize(self, normalId: EnumNormalId, deltaAmount: number): boolean
 	function SetNetworkOwner(self, playerInstance: Player?): nil
 	function SetNetworkOwnershipAuto(self): nil
-	function SubtractAsync(self, parts: { Instance }, collisionfidelity: EnumCollisionFidelity?, renderFidelity: EnumRenderFidelity?): UnionOperation
-	function UnionAsync(self, parts: { Instance }, collisionfidelity: EnumCollisionFidelity?, renderFidelity: EnumRenderFidelity?): UnionOperation
 	TouchEnded: RBXScriptSignal<BasePart>
 	Touched: RBXScriptSignal<BasePart>
+	function GetConnectedParts(self, recursive: boolean?): { BasePart }
+	function GetJoints(self): { BasePart }
+	function GetNetworkOwner(self): Player?
+	function GetTouchingParts(self): { BasePart }
+	function SubtractAsync(self, parts: { BasePart }, collisionfidelity: EnumCollisionFidelity?, renderFidelity: EnumRenderFidelity?): UnionOperation
+	function UnionAsync(self, parts: { BasePart }, collisionfidelity: EnumCollisionFidelity?, renderFidelity: EnumRenderFidelity?): UnionOperation
 end
 
 declare class CornerWedgePart extends BasePart