-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing keys in the dict returned by integrator.read_file() #152
Comments
DocsAlso it seems that this A good place to showcase this important function would be in
|
ultranest can resume with changed settings, including with different parameter names or number of live points. As long as the transform and likelihood function behave the same, it can resume. paramnames is not stored in the hdf5 file, that file is quite minimalistic and as compact as possible. x_dim is needed, because the hdf5 table contains n=k+m columns, made from k unit cube parameters transformed into m physical parameters (k can be not equal to m). It would be good to store it though, at https://github.com/JohannesBuchner/UltraNest/blob/master/ultranest/store.py#L191 I usually resume the run and visualise the results with the sampler object. An alternative is to work with the posterior samples (equal_weighted_post.txt) and |
Ok I understand for the param names. That is easy to add by hand anyway. For the What do you think about adding a |
Description
I'm currently testing the implementation of UltraNest into
gammapy
the science tools for the gamma-ray Cherenkov Telescope CTAO. First results look great !While trying to run, write, read from disk on my test example, I stumbled on this issue :
the
result
dict read back from the hdf5 doesn't contain the exact same keys as the dict from therun()
function, in particular the parameters names.This crashes the plotting function like
cornerplot(result)
.What I Did
Defining the sampler :
Run completes just fine.
paramnames
key is present.Now the following keys are missing:
['ncall', 'paramnames', 'logzerr_single']
The
paramnames
being the most limiting for plotting results. Is this stored in the hdf5 file ?Looking at the source code of
read_file
I'm not sure where this comes into play as the there are multiple calls to other functions.The text was updated successfully, but these errors were encountered: