Assignment 3

[JoeBlanc]

link demo: https://assignment3-cyan.vercel.app/
link repo: https://github.com/JoeBlanc/df-frontend-2023/tree/main/assignment-3

[ngolapnguyen]

Requirements

• All core functionalities present
• Proper TypeScript implementation
• No eslint warnings & errors
• Husky & lint-staged integration

Final result: ❌. Typescript is barely integrated.

Feedbacks

1. Issues with pagination:
   • No visual cue for current page
   • Pages should be re-calculated on search query change. Right now they seem to be fixed

2. Typescript is barely integrated. Across the app you are still using Javascript & implicit any type. You can refer to this repo: https://github.com/longphanquangminh/df-frontend-2023/tree/main/assignment-3. It's a good reference on how we should be approaching this assignment.

You can update this line to true to see the places you are using implicit any:

df-frontend-2023/assignment-3/tsconfig.json

Line 15 in b07ad76

"noImplicitAny": false,

Try defining a type/interface to fix all the issues that pop up after you set the config to true. You'll get a better understanding of how Typescript works 👍