Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non standard delete error message thrown #8

Open
JodyLorah opened this issue Apr 16, 2021 · 1 comment
Open

Non standard delete error message thrown #8

JodyLorah opened this issue Apr 16, 2021 · 1 comment

Comments

@JodyLorah
Copy link
Owner

JodyLorah commented Apr 16, 2021

When I try to delete someone out of index, but a small positive integer index it throws this error.

image.png

When I try to delete someone of a large positive index, I get this error even though my index is a positive integer as specified by the error parameters.

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 20, 2021

Team's Response

See response for #1611.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Long indexes not handled for edit

Since the index is not limited to a particular maximum, the error message is inconsistent.
For a very long integer, instead of telling me that the index is invalid, it says that the command format is invalid.

This error is present for INDEX parameter of edit.

For out of bounds index:

image.png

Invalid command format:

image.png


[original: nus-cs2103-AY2021S2/pe-interim#1611] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

All these issues refer to the app response of invalid index for small invalid index numbers and invalid command for large invalid index numbers.

As stated in the UG, this is the intended behavior.
image.png

As it was already included in the overall notes for the features in the UG, it is omitted from the details of every command using indexing to reduce repetition of details, especially as this situation has a very low possibility of occurring (our target contact list is NUS population, which easily falls within the valid integer range).

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue type

Team chose [type.FunctionalityBug]
Originally [type.FeatureFlaw]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants