Skip to content

Commit

Permalink
Adjust libxposed versions for CI build
Browse files Browse the repository at this point in the history
  • Loading branch information
@JingMatrix
JingMatrix committed Nov 23, 2024
1 parent df74d83 commit c0ecd84
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/core.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,14 @@ jobs:
with:
repository: libxposed/api
path: libxposed/api
ref: a42f85d06eac3373d266a534ab3b31a584b30774

- name: Checkout libxposed/service
uses: actions/checkout@v3
with:
repository: libxposed/service
path: libxposed/service
ref: 4351a735755c86c031a977a62e52005b23048c4d

- name: Setup Java
uses: actions/setup-java@v3
Expand Down

3 comments on commit c0ecd84

@CanerKaraca23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use them as submodules?

@JingMatrix
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honesty, I don't know the reason why the upstream did this. But it doesn't bother me much to change it through workflow files.

If as a submodule, I am somehow forced to implement their new APIs.

@CanerKaraca23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JingMatrix Yes, i recommend you to check this fork of LSPosed, they did new API implement and many more like UI improvements.

https://github.com/re-zero001/LSPosed-Irena

I suggest you to cherry-pick useful commits.

Please sign in to comment.