Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JslConnectDevices blocking when called again > JslDisconnectAndDisposeAll blocking if a device has been disconnected manually #43

Open
benkuper opened this issue Oct 1, 2021 · 6 comments

Comments

@benkuper
Copy link

benkuper commented Oct 1, 2021

Hello,
I'm trying to find a way to have dynamic connection / disconnection detection to avoid having to relaunch the software everytime a joycon has been disconnected or reconnected.
The first JslConnectDevices is working just fine, but if I power down and power again my joycons, calling this function again will be blocking and the function never returns.

Am I doing something wrong or is there a known issue there ?

BTW, the project I'm working on for this is that : https://benjamin.kuperberg.fr/chataigne / https://github.com/benkuper/Chataigne

Thank you for this wonderful lib,
Cheers

@benkuper
Copy link
Author

benkuper commented Oct 1, 2021

I pushed the researched a bit further and figured that JslDisconnectAndDisposeAll is the problematic function, only when at least one controller has been powered down manually. When calling this with all connected controllers still connected, the method returns quickly, but if the controller or one of the connected controllers is not actually connected anymore, the method never returns.

@benkuper benkuper changed the title JslConnectDevices blocking when called again JslConnectDevices blocking when called again > JslDisconnectAndDisposeAll blocking if a device has been disconnected manually Oct 1, 2021
@JibbSmart
Copy link
Owner

Thanks! I'll have a look

@JibbSmart
Copy link
Owner

Sorry it took so long, @benkuper. I think I've fixed the issue in v2.3.0, but not sure, because I haven't had the chance to fully explore it.

@benkuper
Copy link
Author

benkuper commented Jan 7, 2022

Thank you ! Is there a release for 2.3 ?

@JibbSmart
Copy link
Owner

Not yet, I'm afraid, but if you build from the latest on master it'll have what I think is the fix.

@benkuper
Copy link
Author

benkuper commented Jan 8, 2022

Gotcha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants