Iss397 #398
Open
Iss397 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is connected to issue 397 and not 387 |
cbravo135
reviewed
Jul 25, 2023
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
If you are gonna have a readme, put something in it at least. It is fine if you don't finish but put something.
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "nevents" : [2000000], | |||
| "run_params" : ["3pt74"], | |||
There was a problem hiding this comment.
You only are using nevents and run_number from this currently. I would suggest not giving nevents so it just processes all of them, and extracting the run number from the filename. That way you can just eliminate this file.
cbravo135
reviewed
Jul 31, 2023
| @@ -0,0 +1 @@ | |||
| I love biscuits and gravy | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a push request made in pursuance of issue 387