Old comments and FIXMEs in

[sarahgaiser]

When looking deeper into the code in tracking/src/main/java/org/hps/recon/tracking/gbl/, I came across some (old) comments that I just want to bring into people's consciousness again to address/update potentially.

• GBLOutputDriver:
  - Is this still temporary or the final fix?
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/GBLOutputDriver.java

  Lines 277 to 295 in 7e9a7ea

  	//THIS IS TEMPORARY AND NEEDED FOR FIXING THE LOOP ON THE SENSORS ON TRACK FOR KALMAN TRACKS
  	if (hitsOnTrack.size() == 0) {
  	for (TrackerHit hit : trk.getTrackerHits()) {
  	HpsSiSensor sensor = ((HpsSiSensor) ((RawTrackerHit) hit.getRawHits().get(0)).getDetectorElement());
  	if (sensor != null) {
  	sensorHits.put(sensor, hit);
  	sensorNums.put(sensor, i);
  	if (debug)
  	System.out.printf("adding sensor %d \n", i);
  	}
  	if (debug && sensor == null)
  	System.out.printf("TrackerHit null sensor %s \n", hit.toString());
  	i++;
  	}
  	}

  
  - Is this still a todo?
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/GBLOutputDriver.java

  Lines 646 to 647 in 7e9a7ea

  	//it's bias-unbias-bias-unbias-bias-unbias....
  	//TODO add in trackRes the number of hits on tracks ?

• KalmanToGBLDriver:
  - During our meeting today, we discussed that the KF tracks are not refitted to GBL tracks per say but rather GBL tracks are created from KF tracks. How can we adjust the class description to reflect this?
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/KalmanToGBLDriver.java

  Lines 30 to 33 in 7e9a7ea

  	/**
  	* A Driver which refits Kalman Tracks using GBL
  	* in order to get the alignment derivatives
  	*/

• SimpleGBLTrajAliDriver:
  - same comment as above:
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/KalmanToGBLDriver.java

  Lines 30 to 33 in 7e9a7ea

  	/**
  	* A Driver which refits Kalman Tracks using GBL
  	* in order to get the alignment derivatives
  	*/

  
  - marked todo comments: are these still relevant?
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java

  Lines 445 to 453 in 7e9a7ea

  	if (!doCOMAlignment) {
  	//Assign the mothers to the sensors
  	//TODO FIX this part. For the moment the mother of the sensors are chosen by string parsing.
  	MakeAlignmentTree("alignable_fullmodule");
  	//Dump the constrain file
  	MakeAlignmentConstraintFile();
  	}

  
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java

  Lines 1203 to 1204 in 7e9a7ea

  	//Cmatrix is a 6by6 (get the nCols) TODO
  	for (int icol = 0 ; icol < 6; icol++) {

  
  - Comments suggested changes: are these still relevant?
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java

  Lines 825 to 827 in 7e9a7ea

  	//This should GBL Trajectories for both the ST+GBL and KF+GBL depending on the setup.
  	//I think this should take the track->trackerHits and refit those with a GBL otherwise I think I miss the momentum constraint.. ?

  
  

  hps-java/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java

  Line 867 in 7e9a7ea

  //For the moment I form the global derivatives here, but in principle I should create them when I run the trajectory creator.