New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flags in the ReconParticleDriver clusterMatcher #1029

Open

pbutti opened this issue Apr 23, 2024 · 2 comments

Contributor

pbutti commented Apr 23, 2024

Currently the wrong flag is used to activate the cluster position corrections.
The matcher uses the useTrackPositionClusterCorrection flag instead of useClusterCorrectionPosition.
Matcher: https://outlook.office.com/mail/safelink.html?url=https://github.com/JeffersonLab/hps-java/blob/master/recon/src/main/java/org/hps/recon/utils/TrackClusterMatcherMinDistance.java#L129&corid=d5e86425-55a9-66d9-b160-1aac0dae1870
Called by: https://github.com/JeffersonLab/hps-java/blob/master/recon/src/main/java/org/hps/recon/particle/ReconParticleDriver.java#L524

Is this intended ? @alspellm @sarahgaiser @mholtrop

Contributor Author

pbutti commented May 10, 2024

ping:
@alspellm @sarahgaiser @mholtrop

Collaborator

sarahgaiser commented May 10, 2024

I don't know much about this. What do you want me to check here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment