Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rarely-used plugins should be optional targets, outdated ones removed #843

Open
aaust opened this issue Sep 27, 2024 · 5 comments
Open

Rarely-used plugins should be optional targets, outdated ones removed #843

aaust opened this issue Sep 27, 2024 · 5 comments

Comments

@aaust
Copy link
Contributor

aaust commented Sep 27, 2024

We currently compile 165 plugins by default. This takes time and the compiled libraries take up disk space. Only about 50% of the plugins are regularly used for in production, for monitoring, calibration or analysis. Many others are outdated or only serve a very limited purpose.

Could we identify which plugins are important to be included in the default build, which ones can be kept as optional targets and which ones can be retired? Here is a list of all plugins that are currently compiled by default. I marked the ones used in production:

  • 1p1pi1pi0.so
  • 1p2pi.so
  • 2trackskim.so
  • b1pi_hists.so
  • B3pi_eff_missgamma.so
  • B3pi_eff_misspim.so
  • B3pi_eff_misspip.so
  • B3pi_eff_missprot.so
  • BCAL_attenlength_gainratio.so
  • BCAL_Eff.so
  • BCAL_gainmatrix.so
  • BCAL_Hadronic_Eff.so
  • BCAL_inv_mass.so
  • BCAL_LEDonline.so
  • BCAL_LED.so
  • BCAL_LED_time.so
  • BCAL_online.so
  • BCAL_point_calib.so
  • BCAL_point_time.so
  • BCAL_saturation.so
  • BCAL_SiPM_saturation.so
  • BCAL_TDC_Timing.so
  • BEAM_online.so
  • bigevents_skim.so
  • cal_high_energy_skim.so
  • CCAL_online.so
  • CDC_amp.so
  • cdcbcal_skim.so
  • CDC_dedx.so
  • CDC_drift.so
  • CDC_Efficiency.so
  • CDC_expert_2.so
  • CDC_expert.so
  • cdc_goodtrack_skim.so
  • CDC_online.so
  • CDC_PerStrawReco.so
  • CDC_roc_hits.so
  • CDC_TimeToDistance.so
  • coherent_peak_skim.so
  • compton_neutral_skim.so
  • compton.so
  • cppFMWPC_ana.so
  • cppFMWPC.so
  • cpp_hists.so
  • cpp_itrig.so
  • cpp_skim.so
  • danarest.so
  • DAQ_online.so
  • DAQTreeBCAL.so
  • DAQTree.so
  • dedx_tree.so
  • dirc_hists.so
  • DIRC_online.so
  • dirc_reactions.so
  • dirc_tree.so
  • EPICS_dump.so
  • es_test.so
  • eta2g_primexd_skim.so
  • eta6g_primexd_skim.so
  • etapi0_primexd_skim.so
  • EventTagPi0.so
  • evio-hddm.so
  • evio_writer.so
  • exclusivepi0skim.so
  • fa125_itrig.so
  • fcal_charged.so
  • FCAL_cpp.so
  • FCAL_Hadronic_Eff.so
  • FCAL_invmass.so
  • FCAL_LED_shifts.so
  • FCALLEDTree.so
  • FCAL_online.so
  • FCAL_Pi0HFA.so
  • FCAL_Pi0TOF.so
  • FCAL_TimingOffsets_Primex.so
  • FDC_Efficiency.so
  • FDC_InternalAlignment.so
  • FDC_online.so
  • FDCProjectionResiduals.so
  • FMWPC_online.so
  • FMWPC_Performance.so
  • HELI_online.so
  • highlevel_online.so
  • HLDetectorTiming.so
  • imaging.so
  • L1_online.so
  • lowlevel_online.so
  • lumi_mon.so
  • lut_dirc.so
  • mcthrown_hists.so
  • mcthrown_tree.so
  • MilleFieldOff.so
  • MilleFieldOn.so
  • MilleKs.so
  • monitoring_hists.so
  • npp_hists.so
  • npp_skim.so
  • occupancy_online.so
  • omega_skim.so
  • p2gamma_hists.so
  • p2k_hists.so
  • p2pi0_hists.so
  • p2pi_hists.so
  • p3pi_hists.so
  • p4pi_hists.so
  • pedestal_online.so
  • phi_skim.so
  • pi0bcalskim.so
  • pi0fcalskim.so
  • pi0fcaltofskim.so
  • Pi0Finder.so
  • pid_dirc.so
  • ppi0gamma_hists.so
  • primex-online.so
  • PSC_online.so
  • PSC_TW.so
  • PS_E_calib.so
  • PS_flux.so
  • PS_online.so
  • PSPair_online.so
  • ps_skim.so
  • PS_timing.so
  • randomtrigger_skim.so
  • ReactionEfficiency.so
  • ReactionFilter.so
  • RF_online.so
  • RSAI_KO.so
  • run_summary.so
  • scaler_primex.so
  • SC_Eff.so
  • single_neutral_skim.so
  • ST_online_efficiency.so
  • ST_online_lowlevel.so
  • ST_online_multi.so
  • ST_online_tracking.so
  • ST_online_Tresolution.so
  • ST_Propagation_Time.so
  • ST_Tresolution.so
  • st_tw_corr_auto.so
  • syncskim.so
  • TAGGER_online.so
  • TAGH_online.so
  • TAGH_timewalk.so
  • TAGM_clusters.so
  • TAGM_online.so
  • TAGM_TW.so
  • timing_online.so
  • TOF_calib.so
  • TOF_Eff.so
  • TOF_online.so
  • TOF_TDC_shift.so
  • TPOL_online.so
  • TPOL_tree.so
  • trackeff_hists.so
  • trackeff_missing.so
  • TrackingPulls.so
  • TrackingPulls_straight.so
  • track_skimmer.so
  • TRD_hists.so
  • TRD_online.so
  • trigger_skims.so
  • TRIG_online.so
  • truth_dirc.so
  • TS_scaler.so
  • twogamma_fcal_skim.so
@nsjarvis
Copy link
Contributor

nsjarvis commented Sep 27, 2024 via email

@sdobbs
Copy link
Contributor

sdobbs commented Oct 3, 2024

what does "retired" mean, here? removed from the repo?

@aaust
Copy link
Contributor Author

aaust commented Oct 3, 2024

@sdobbs Correct. In scenarios where a plugin was superseded by another one or if a plugin would require significant changes to even compile, we could remove it.

@sdobbs
Copy link
Contributor

sdobbs commented Oct 7, 2024

One thing we could consider is making some of the plugin subdirectories optional targets - like if you had to explicitly request the alignment or monitoring plugins to be built

@sdobbs
Copy link
Contributor

sdobbs commented Oct 7, 2024

Here are my comments / opinions on these plugins:

  • 1p1pi1pi0.so - optional
  • 1p2pi.so - optional
  • 2trackskim.so - optional
  • b1pi_hists.so - default
  • B3pi_eff_missgamma.so - optional, but can we maybe merge these 4 B3pi_eff plugins? we could add flags to toggle which to use
  • B3pi_eff_misspim.so
  • B3pi_eff_misspip.so
  • B3pi_eff_missprot.so
  • BCAL_attenlength_gainratio.so - default
  • BCAL_Eff.so - default
  • BCAL_gainmatrix.so - optional
  • BCAL_Hadronic_Eff.so - default
  • BCAL_inv_mass.so - default
  • BCAL_LEDonline.so - is this actually used, and is it actually run online? would be good to merge this with BCAL_LED if possible, since there seems to be some redundancy
  • BCAL_LED.so
  • BCAL_LED_time.so - freezer
  • BCAL_online.so
  • BCAL_point_calib.so - freezer
  • BCAL_point_time.so - freezer
  • BCAL_saturation.so - optional
  • BCAL_SiPM_saturation.so - optional
  • BCAL_TDC_Timing.so - default
  • BEAM_online.so - default
  • bigevents_skim.so - optional
  • cal_high_energy_skim.so - optional
  • CCAL_online.so - default
  • CDC_amp.so - default
  • cdcbcal_skim.so - optional
  • CDC_dedx.so - default
  • CDC_drift.so - default
  • CDC_Efficiency.so - default
  • CDC_expert_2.so
  • CDC_expert.so
  • cdc_goodtrack_skim.so - couldn't find this for some reason
  • CDC_online.so
  • CDC_PerStrawReco.so
  • CDC_roc_hits.so
  • CDC_TimeToDistance.so
  • coherent_peak_skim.so - optional
  • compton_neutral_skim.so - optional
  • compton.so - optional
  • cppFMWPC_ana.so - optional
  • cppFMWPC.so - optional
  • cpp_hists.so - optional
  • cpp_itrig.so - optional
  • cpp_skim.so - optional
  • danarest.so - default
  • DAQ_online.so - default
  • DAQTreeBCAL.so - optional
  • DAQTree.so - optional
  • dedx_tree.so - optional
  • dirc_hists.so - default
  • DIRC_online.so - default
  • dirc_reactions.so - optional
  • dirc_tree.so - optional
  • EPICS_dump.so - optional
  • es_test.so - optional
  • eta2g_primexd_skim.so - optional
  • eta6g_primexd_skim.so - optional
  • etapi0_primexd_skim.so - optional
  • EventTagPi0.so - optional
  • evio-hddm.so - optional
  • evio_writer.so - default
  • exclusivepi0skim.so - optional
  • fa125_itrig.so - default
  • fcal_charged.so - remove
  • FCAL_cpp.so - optional
  • FCAL_Hadronic_Eff.so - default
  • FCAL_invmass.so - default
  • FCAL_LED_shifts.so - optional
  • FCALLEDTree.so - optional
  • FCAL_online.so - default
  • FCAL_Pi0HFA.so - optional
  • FCAL_Pi0TOF.so - optional
  • FCAL_TimingOffsets_Primex.so - optional
  • FDC_Efficiency.so - default
  • FDC_InternalAlignment.so - optional
  • FDC_online.so - default
  • FDCProjectionResiduals.so - optional
  • FMWPC_online.so - optional
  • FMWPC_Performance.so - optional
  • HELI_online.so - optional
  • highlevel_online.so - default
  • HLDetectorTiming.so - default
  • imaging.so - default
  • L1_online.so - default
  • lowlevel_online.so - default
  • lumi_mon.so - default
  • lut_dirc.so - optional
  • mcthrown_hists.so - optional
  • mcthrown_tree.so - default
  • MilleFieldOff.so - optional
  • MilleFieldOn.so - optional
  • MilleKs.so - optional
  • monitoring_hists.so - default
  • npp_hists.so - optional
  • npp_skim.so - optional
  • occupancy_online.so - default
  • omega_skim.so - optional
  • p2gamma_hists.so - optional
  • p2k_hists.so - optional
  • p2pi0_hists.so - optional
  • p2pi_hists.so - default
  • p3pi_hists.so - default
  • p4pi_hists.so - optional
  • pedestal_online.so - optional
  • phi_skim.so - optional
  • pi0bcalskim.so - optional
  • pi0fcalskim.so - optional
  • pi0fcaltofskim.so - default
  • Pi0Finder.so - optional - not sure what this is
  • pid_dirc.so - optional
  • ppi0gamma_hists.so
  • primex-online.so - optional
  • PSC_online.so - default
  • PSC_TW.so - optional
  • PS_E_calib.so - optional
  • PS_flux.so - default
  • PS_online.so - default
  • PSPair_online.so - default
  • ps_skim.so - default
  • PS_timing.so - default - could merge this with one of the other PS plugins
  • randomtrigger_skim.so -optional
  • ReactionEfficiency.so - default
  • ReactionFilter.so - default
  • RF_online.so - default
  • RSAI_KO.so - optional
  • run_summary.so - optional
  • scaler_primex.so - optional
  • SC_Eff.so - optional
  • single_neutral_skim.so - optional
  • ST_online_efficiency.so - optional
  • ST_online_lowlevel.so - default - note that the start counter plugins should be refreshed
  • ST_online_multi.so - optional - probably get rid of this?
  • ST_online_tracking.so - optional - probably get rid of this?
  • ST_online_Tresolution.so - optional - probably get rid of this?
  • ST_Propagation_Time.so
  • ST_Tresolution.so - default
  • st_tw_corr_auto.so - optional
  • syncskim.so - default
  • TAGGER_online.so - default
  • TAGH_online.so - default
  • TAGH_timewalk.so - default
  • TAGM_clusters.so - optional
  • TAGM_online.so - default
  • TAGM_TW.so - default
  • timing_online.so - optional
  • TOF_calib.so - default
  • TOF_Eff.so
  • TOF_online.so - default
  • TOF_TDC_shift.so - default
  • TPOL_online.so - default
  • TPOL_tree.so - optional
  • trackeff_hists.so - optional
  • trackeff_missing.so - default
  • TrackingPulls.so - default
  • TrackingPulls_straight.so - optional
  • track_skimmer.so optional
  • TRD_hists.so optional
  • TRD_online.so optional
  • trigger_skims.so - default
  • TRIG_online.so - default
  • truth_dirc.so optional
  • TS_scaler.so optional
  • twogamma_fcal_skim.so optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants