Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need/want a geometry manager #59

Closed
baltzell opened this issue Jun 29, 2023 · 1 comment · May be fixed by #346
Closed

Need/want a geometry manager #59

baltzell opened this issue Jun 29, 2023 · 1 comment · May be fixed by #346

Comments

@baltzell
Copy link
Collaborator

To facilitate moving to using run number instead of variation for geometry, which means moving access from ReconEngine.init() to processEvent, which means caching and thread-safety and etc, hence the desire for a "manager".

@baltzell
Copy link
Collaborator Author

Switching to a runNumberChanged hook instead, and leaving it to the engines to reload their geometry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant