Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve runtime warning #68

Open
baltzell opened this issue May 20, 2024 · 1 comment
Open

Resolve runtime warning #68

baltzell opened this issue May 20, 2024 · 1 comment

Comments

@baltzell
Copy link
Collaborator

baltzell commented May 20, 2024

In file included from input_line_14:1:
In file included from /u/group/clas12/packages/clas12-mcgen/3.01/clas12-elSpectro/src/C12Utils.h:4:
/group/clas12/packages/clas12-mcgen/3.01/clas12-elSpectro/elSpectro/core/LundWriter.h:27:20: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
     ~LundWriter() final;
                   ^
/group/clas12/packages/clas12-mcgen/3.01/clas12-elSpectro/elSpectro/core/LundWriter.h:16:9: note: mark 'elSpectro::LundWriter' as 'final' to silence this warning
  class LundWriter : public Writer {
        ^
@dglazier
Copy link
Collaborator

This looks like an elspectro warning not clas12root.
It is a non-urgent fix, newer compilers prefer if the class is labelled final if the destructor is.It should be fixed next time I update clas12-elspectro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants