Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please let us set player executable path #31

Open
barisahmet opened this issue Jun 14, 2016 · 5 comments
Open

Please let us set player executable path #31

barisahmet opened this issue Jun 14, 2016 · 5 comments

Comments

@barisahmet
Copy link

I am using livestreamer "portable" way (in dropbox), and my video player path varies in different computers. It would be good if I can set player executable in the GUI (--player parameter in livestreamer).

@s1mpl3x
Copy link
Collaborator

s1mpl3x commented Jun 15, 2016

older versions of skadi had a videoplayer config field, but i removed it as it seemed more clear to leave all that to livestreamer and i'd prefer to keep it that way. However adding a config value for the parameters to pass to livestreamer might be a possibility.

@barisahmet
Copy link
Author

Yeah that is what I want, would be nice if I can pass --player to skadi :)
On Jun 15, 2016 14:34, "Jan Strauß" [email protected] wrote:

older versions of skadi had a videoplayer config field, but i removed it
as it seemed more clear to leave all that to livestreamer and i'd prefer to
keep it that way. However adding a config value for the parameters to pass
to livestreamer might be a possibility.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADH80qlUDneTxzrGPZuQMh9XcWneJNkYks5qL-NXgaJpZM4I1Rdx
.

s1mpl3x added a commit that referenced this issue Jun 24, 2016
@s1mpl3x
Copy link
Collaborator

s1mpl3x commented Jun 24, 2016

I've added a new config value to implement this:

<skadi_data>
    [...]
    <livestreamer_args>
        <arg>--player=C:\Program Files (x86)\VideoLAN\VLC\vlc.exe</arg>
    </livestreamer_args>
</skadi_data>

this way it is possible to pass multiple args to livestreamer without doing any stupid string split fu.
I don't want to add it to the gui atm, hope this works for you

@s1mpl3x
Copy link
Collaborator

s1mpl3x commented Jun 24, 2016

skadi-2.5.1-SNAPSHOT_7729993.zip

current dev snapshot, dont know when i'll release the next version

@barisahmet
Copy link
Author

It should work, thanks man!

On Fri, Jun 24, 2016 at 10:12 PM, Jan Strauß [email protected]
wrote:

skadi-2.5.1-SNAPSHOT_7729993.zip
https://github.com/s1mpl3x/skadi/files/332410/skadi-2.5.1-SNAPSHOT_7729993.zip

current dev snapshot, dont know when i'll release the next version


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADH80sS90HldjXjmrBKCd45GmHK46uO_ks5qPCwEgaJpZM4I1Rdx
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants