Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGSF hard dependency when using vertical_cleaner #43

Closed
emotion3459 opened this issue Nov 28, 2024 · 0 comments
Closed

RGSF hard dependency when using vertical_cleaner #43

emotion3459 opened this issue Nov 28, 2024 · 0 comments

Comments

@emotion3459
Copy link
Contributor

Should only be required when processing an fp32 clip.
LightArrowsEXE added a commit that referenced this issue Nov 28, 2024
@LightArrowsEXE
pick_rgplugin_stype: New function, use where necessary
83a93d1 
Closes #43.

This introduces a new function to replace `vstools.pick_func_stype` with a specialised one for removegrain plugins. This means the user is no longer required to have both rgvs and RGSF installed for functions to work, and that once zsmooth (https://github.com/adworacz/zsmooth?tab=readme-ov-file#implemented-featuresfunctions) has implemented every function called here, we can easily make use of it here if available.

This also returns "DependencyNotFound" errors as used in other JET packages.
@LightArrowsEXE LightArrowsEXE mentioned this issue Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pick_rgplugin_stype: New function, use where necessary Jaded-Encoding-Thaumaturgy/vs-rgtools
1 participant
@emotion3459