Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Output Keys #3

Open
JackGeraghty opened this issue Sep 27, 2021 · 0 comments
Open

Refactor Output Keys #3

JackGeraghty opened this issue Sep 27, 2021 · 0 comments

Comments

@JackGeraghty
Copy link
Owner

Each node currently requires an output_key, this key can be set to None but in the instance where it isn't it holds a string value. This forces a node to have at most one output_key. From implementing some of the ViSQOL nodes there is a need for multiple values to be added to the results dictionary within a single node.

A potential refactor of this functionality would include changing the output key to be either a string OR a list of strings. When implementing a node an order can then be defined for the output keys and consequently ordered as such in a JSON definition..

Could look like for example:

{
    "node": {
        "output_keys": ["key_one", "key_two", ...]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant