Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded Pipeline Diagram #2

Open
JackGeraghty opened this issue Sep 16, 2021 · 0 comments
Open

Expanded Pipeline Diagram #2

JackGeraghty opened this issue Sep 16, 2021 · 0 comments

Comments

@JackGeraghty
Copy link
Owner

After refactoring the code to move away from NetworkX, the functionality to create an expanded version of the pipeline diagram hasn't fully worked. This issue could have existed before since it was only noticed when creating a complicated pipeline for testing out three visqol configurations against each other.

Issue arises from trying to connect nodes together that belong to either a LoopNode or an EncapsulationNode. To create the expanded diagram, the Loop or Encapsulation Nodes need to be connected to the first node in their subgraph. Then the leaf nodes of that subgraph need to be connected to the children of the Loop or Encapsulation Nodes. On the top level, this works ok. It is only when you have nested Encapsulation Nodes within LoopNodes and then another Loop Node within the Encapsulation Node. In this case, an inner LoopNode, belonging to the EncapsulationNode, is a leaf node and the previous setup tries to connect this node to the nodes belonging to the outermost LoopNode.

It has been improved from how broken it was before. Now, when finding leaf nodes, it ignores LoopNodes. The output from this is a lot cleaner than it was before. The issue still remains though of it not connecting the expanded version properly.
graphviz (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant