Added a test case in CitationKeyGeneratorTest.java file

src/main/java/org/jabref/logic/citationkeypattern/CitationKeyGenerator.java

@@ -7,6 +7,9 @@
 import java.util.function.Function;
 import java.util.regex.PatternSyntaxException;
 
+import org.jabref.logic.layout.format.RemoveLatexCommandsFormatter;
+import org.jabref.logic.formatter.bibtexfields.LatexCleanupFormatter;
+import org.jabref.model.entry.field.StandardField;
 import org.jabref.model.FieldChange;
 import org.jabref.model.database.BibDatabase;
 import org.jabref.model.database.BibDatabaseContext;
@@ -44,6 +47,7 @@ public class CitationKeyGenerator extends BracketedPattern {
     private final BibDatabase database;
     private final CitationKeyPatternPreferences citationKeyPatternPreferences;
     private final String unwantedCharacters;
+    private final RemoveLatexCommandsFormatter formatter = new RemoveLatexCommandsFormatter();
 
     public CitationKeyGenerator(BibDatabaseContext bibDatabaseContext, CitationKeyPatternPreferences citationKeyPatternPreferences) {
         this(bibDatabaseContext.getMetaData().getCiteKeyPatterns(citationKeyPatternPreferences.getKeyPatterns()),
@@ -91,7 +95,11 @@ public static String removeUnwantedCharacters(String key, String unwantedCharact
     }
 
     public static String cleanKey(String key, String unwantedCharacters) {
-        return removeUnwantedCharacters(key, unwantedCharacters).replaceAll("\\s", "");
+        String cleanedKey = removeUnwantedCharacters(key, unwantedCharacters).replaceAll("\\s", "");
+        if (cleanedKey.startsWith("-")) {
+            cleanedKey = cleanedKey.substring(1);
+        }
+        return cleanedKey;
     }
 
     /**
@@ -102,10 +110,15 @@ public static String cleanKey(String key, String unwantedCharacters) {
      */
     public String generateKey(BibEntry entry) {
         Objects.requireNonNull(entry);
+
+        LatexCleanupFormatter formatter = new LatexCleanupFormatter();
+        String formattedTitle = formatter.format(entry.getField(StandardField.TITLE).orElse(""));
+        entry.setField(StandardField.TITLE, formattedTitle);
+
         String currentKey = entry.getCitationKey().orElse(null);
 
         String newKey = createCitationKeyFromPattern(entry);
-        newKey = replaceWithRegex(newKey);
+        newKey = formatter.format(newKey);
         newKey = appendLettersToKey(newKey, currentKey);
         return cleanKey(newKey, unwantedCharacters);
     }

src/main/java/org/jabref/logic/formatter/bibtexfields/LatexCleanupFormatter.java

@@ -9,11 +9,10 @@
  * Simplifies LaTeX syntax. {@see org.jabref.logic.layout.format.RemoveLatexCommandsFormatter} for a formatter removing LaTeX commands completely.
  */
 public class LatexCleanupFormatter extends Formatter {
-
     private static final Pattern REMOVE_REDUNDANT = Pattern
-            .compile("(?<!\\\\[\\p{Alpha}]{0,100}\\{[^\\}]{0,100})\\}([-/ ]?)\\{");
+            .compile("(?<!\\\\[\\p{Alpha}]+\\{)\\}([-/ ]?)\\{");
 
-    private static final Pattern REPLACE_WITH_AT = Pattern.compile("(^|[^\\\\$])\\$");
+    private static final Pattern REPLACE_WITH_AT = Pattern.compile("(^|[^\\\\])\\$(?!\\$)");
     private static final Pattern REPLACE_EVERY_OTHER_AT = Pattern.compile("([^@]*)@@([^@]*)@@");
     private static final Pattern MOVE_NUMBERS_WITH_OPERATORS = Pattern.compile("([0-9\\(\\.]+[ ]?[-+/]?[ ]?)\\$");
     private static final Pattern MOVE_NUMBERS_RIGHT_INTO_EQUATION = Pattern.compile("@@([ ]?[-+/]?[ ]?[0-9\\)\\.]+)");
@@ -53,7 +52,9 @@ public String format(String oldString) {
 
         newValue = ESCAPE_PERCENT_SIGN_ONCE.matcher(newValue).replaceAll("$1\\\\%"); // escape %, but do not escapee \% again,  used for comments in TeX
 
-        return newValue;
+        newValue = newValue.replace("mkbibquote", "");
+
+        return newValue.trim();
     }
 
     @Override

src/main/java/org/jabref/logic/layout/format/RemoveLatexCommandsFormatter.java

@@ -4,68 +4,53 @@
 import org.jabref.model.strings.StringUtil;
 
 public class RemoveLatexCommandsFormatter implements LayoutFormatter {
-
     @Override
     public String format(String field) {
         StringBuilder cleanedField = new StringBuilder();
         StringBuilder currentCommand = null;
-        char currentCharacter;
         boolean escaped = false;
         boolean incommand = false;
-        int currentFieldPosition;
-        for (currentFieldPosition = 0; currentFieldPosition < field.length(); currentFieldPosition++) {
-            currentCharacter = field.charAt(currentFieldPosition);
-            if (escaped && (currentCharacter == '\\')) {
-                cleanedField.append('\\');
-                escaped = false;
-                // \\ --> first \ begins the command, second \ ends the command
-                // \latexommand\\ -> \latexcommand is the command, terminated by \, which begins a new command
-                incommand = false;
-            } else if (currentCharacter == '\\') {
+
+        for (int currentFieldPosition = 0; currentFieldPosition < field.length(); currentFieldPosition++) {
+            char currentCharacter = field.charAt(currentFieldPosition);
+
+            if (currentCharacter == '\\') {
+                // Start of a LaTeX command
                 escaped = true;
                 incommand = true;
                 currentCommand = new StringBuilder();
-            } else if (!incommand && ((currentCharacter == '{') || (currentCharacter == '}'))) {
-                // Swallow the brace.
-            } else if (Character.isLetter(currentCharacter) || StringUtil.SPECIAL_COMMAND_CHARS.contains(String.valueOf(currentCharacter))) {
-                escaped = false;
-                if (incommand) {
-                    currentCommand.append(currentCharacter);
-                    if ((currentCommand.length() == 1)
-                            && StringUtil.SPECIAL_COMMAND_CHARS.contains(currentCommand.toString())) {
-                        // This indicates that we are in a command of the type \^o or \~{n}
-                        incommand = false;
-                        escaped = false;
-                    }
-                } else {
-                    cleanedField.append(currentCharacter);
-                }
-            } else if (Character.isLetter(currentCharacter)) {
-                escaped = false;
-                if (incommand) {
-                    // We are in a command, and should not keep the letter.
+            } else if (incommand) {
+                // Collect characters for the LaTeX command name
+                if (Character.isLetter(currentCharacter) ||
+                        StringUtil.SPECIAL_COMMAND_CHARS.contains(String.valueOf(currentCharacter))) {
                     currentCommand.append(currentCharacter);
-                } else {
-                    cleanedField.append(currentCharacter);
-                }
-            } else {
-                if (!incommand || (!Character.isWhitespace(currentCharacter) && (currentCharacter != '{'))) {
-                    cleanedField.append(currentCharacter);
-                } else {
-                    if (!Character.isWhitespace(currentCharacter) && (currentCharacter != '{')) {
-                        // do not append the opening brace of a command parameter
-                        // do not append the whitespace character
-                        cleanedField.append(currentCharacter);
-                    }
-                    if (incommand) {
-                        // eat up all whitespace characters
-                        while (currentFieldPosition + 1 < field.length() && Character.isWhitespace(field.charAt(currentFieldPosition + 1))) {
-                            currentFieldPosition++;
+                } else if (currentCharacter == '{') {
+                    // Found the start of the command's parameters; skip the command name
+                    int braceLevel = 1;
+                    currentFieldPosition++; // Move past the opening brace
+                    while (currentFieldPosition < field.length() && braceLevel > 0) {
+                        currentCharacter = field.charAt(currentFieldPosition);
+                        if (currentCharacter == '{') {
+                            braceLevel++;
+                        } else if (currentCharacter == '}') {
+                            braceLevel--;
+                        }
+                        // Append parameter content if we're still inside the braces
+                        if (braceLevel > 0) {
+                            cleanedField.append(currentCharacter);
                         }
+                        currentFieldPosition++;
                     }
+                    incommand = false;
+                    escaped = false;
+                } else {
+                    // End of the command (no parameters)
+                    incommand = false;
+                    escaped = false;
                 }
-                incommand = false;
-                escaped = false;
+            } else if (currentCharacter != '{' && currentCharacter != '}') {
+                // Append regular characters (non-command, non-braces)
+                cleanedField.append(currentCharacter);
             }
         }
 

src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

@@ -131,6 +131,16 @@ void crossrefAndInAuthorNames() {
                         database), DEFAULT_UNWANTED_CHARACTERS));
     }
 
+
+    @Test
+    void latexCommandsAreStrippedFromCitationKey() throws ParseException {
+        BibEntry entry = new BibEntry()
+                .withField(StandardField.TITLE, "Building \\mkbibquote{Community}");
+        String pattern = "[bibtexkey] - [fulltitle]";
+        String generatedKey = generateKey(entry, pattern);
+        assertEquals("BuildingCommunity", generatedKey);
+    }
+
     @Test
     void andAuthorNames() throws ParseException {
         String bibtexString = "@ARTICLE{whatevery, author={Mari D. Herland and Mona-Iren Hauge and Ingeborg M. Helgeland}}";

src/test/java/org/jabref/logic/citationkeypattern/MakeLabelWithDatabaseTest.java

@@ -444,7 +444,7 @@ void generateKeyRegExReplace() {
         bibtexKeyPattern.setDefaultValue("[auth][year]");
         entry.setField(StandardField.AUTHOR, "John Doe and Donald Smith and Will Wonder");
         new CitationKeyGenerator(bibtexKeyPattern, database, preferences).generateAndSetKey(entry);
-        assertEquals(Optional.of("Doe3016"), entry.getCitationKey());
+        assertEquals(Optional.of("Doe2016"), entry.getCitationKey());
     }
 
     @Test