Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add group" should additionally be a button "on hover" #12289

Open
koppor opened this issue Oct 25, 2022 · 4 comments
Open

"Add group" should additionally be a button "on hover" #12289

koppor opened this issue Oct 25, 2022 · 4 comments

Comments

@koppor
Copy link
Member

koppor commented Oct 25, 2022

image

Also for "All groups":

grafik

  • The semantics of the button at "All groups" is "Add group"
  • The semantics of the button at a group is "Add subgroup"

The plus symbol could be the one of the PR #9329.

grafik

The implementation needs to be differen.t


Historic text:

image

(This is a duplicate of JabRef#529)

Other alternatives are listed in: #8398

@koppor koppor changed the title "Add group" should be a button "on hover" "Add group" should additionally be a button "on hover" Nov 7, 2022
@koppor koppor added the ui label Nov 7, 2022
@DumitruDruta
Copy link
Contributor

I am working now on this issue. Can someone assign it to me.

@koppor
Copy link
Member Author

koppor commented Jan 11, 2024

I assigned you. Looking forward! I hope, JavaFX is manageable...

@DumitruDruta
Copy link
Contributor

DumitruDruta commented Jan 18, 2024

I created a draft pull request for the issue. I have not managed to implement the issue completely and I need some help with a couple of things that I mentioned in the pull request. Also for some reason not all the checks passed when I created the pull request, even though the code seems to run well on my machine, so I might need some support on that as well.

@koppor
Copy link
Member Author

koppor commented Mar 6, 2024

@DumitruDruta There was no activity in the PR, thus I think, this issue is free to take again. Interested contributors can see your changes and think what to do differently.

For questions regarding a PR, please ask at the PR itself.

I nevertheless reply here.

One can click on the red crosses on GitHub and scroll through the errors:

FAILURE: Build failed with an exception.

    org.jabref.config.rewrite.cleanup
        org.openrewrite.staticanalysis.UnnecessaryParentheses
These recipes would make changes to src/main/java/org/jabref/gui/groups/GroupTreeView.java:
    org.jabref.config.rewrite.cleanup
        org.openrewrite.staticanalysis.UnnecessaryParentheses
Report available:
    /home/runner/work/jabref/jabref/build/reports/rewrite/rewrite.patch
Run 'gradle rewriteRun' to apply the recipes.

> Task :rewriteDryRun FAILED
* What went wrong:
Execution failed for task ':rewriteDryRun'.
> java.lang.RuntimeException: Applying recipes would make changes. See logs for more details.

The text says

Run 'gradle rewriteRun' to apply the recipes.

This is possible on the local machine. That a code compiles is one part of the whole story, but it should also follow some code style rules, which are checked by OpenRewrite (and which also rewrites the code if instructed so).

@koppor koppor transferred this issue from JabRef/jabref-koppor Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Normal priority
Development

No branches or pull requests

2 participants