-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: cleaner output #14
Comments
Made some good progress on this: d41d638 Still need to work on sorting conflicting actual/expected values output. For now it is still the old format:
I'll work on getting it down to 1 line, just needs to be disentangled a bit. All other requested changes to output have been made with the exception of "--" prefix. It's a little tricky to add this as the code is written, I'll explore options. |
Ok!
The “--“ was just my way of getting around markdown making it an unordered
list in GitHub. Any bullet point is fine by me.
…On Sun, Jan 28, 2024 at 13:24 eddycolloton ***@***.***> wrote:
Made some good progress on this: d41d638
<d41d638>
Still need to work on sorting conflicting actual/expected values output.
For now it is still the old format:
Some specified [metadata tool] fields or values are missing or don't match:
[name of field]
Expected: [value]
Actual: [value]
I'll work on getting it down to 1 line, just needs to be disentangled a
bit.
All other requested changes to output have been made with the exception of
"--" prefix. It's a little tricky to add this as the code is written, I'll
explore options.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMZZEODONR7ZLUBH7GJJ2LYQ2JWXAVCNFSM6AAAAABCOJ2CVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY4DEMRUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Output for conflicting actual/expected values is cleaned up: 50e46c2 |
ffmpeg stream progress is now printed to the terminal as a percentage, and mediaconch policy rule fails are also printed to the terminal: 9e1e43c |
@BleakleyMcD As of this commit I've finally gone through and revamped all of the new line characters to make spacing more uniform, and coded consistently. Changed some fonts too. Take a look when you can and if you approve I'll close out this issue: 517fcd3 |
Could it look something more like this, including grouping and spacing. Bold is green text, italic is red. Everything else can be normal. I liked the turquoise-ish color you chose for normal.
Running the following processes and checks on JPC_AV_01637.mkv
2024-01-26 11:46:21
-- config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/config.yaml
-- command_config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/command_config.yaml
-- The file name 'JPC_AV_01637.mkv' is valid.
-- Video ID matches directory name
-- Metadata files will be written to /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637
-- Using MediaConch policy JPC_AV_NTSC_MKV_2023-11-21.xml
-- running command: mediaconch -p /Users/medialab/github/JPC_AV_videoQC-main/config/JPC_AV_NTSC_MKV_2023-11-21.xml "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" -oc /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediaconch_output.csv
-- MediaConch policy failed
-- running command: ffprobe -v error -hide_banner -show_format -show_streams -print_format json "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_ffprobe_output.txt
-- No 'encoder settings' in ffprobe output
-- All specified fields and values found in the ffprobe output.
-- running command: exiftool "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_exiftool_output.txt
-- All specified fields and values found in the Exiftool output.
-- running command: mediainfo -f "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediainfo_output.txt
-- The specified MediaInfo fields or values for embedded metadata are below:
-- Please note that these warnings on metadata are just used to help any issues with your file. If they are not relevant at this point in your workflow, just ignore this. Thanks!
-- Processing complete. Output files saved in the directory: /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637
If the metadata fields do have an associated value stored, please have the script say:
The text was updated successfully, but these errors were encountered: