Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: cleaner output #14

Open
BleakleyMcD opened this issue Jan 28, 2024 · 5 comments
Open

feature request: cleaner output #14

BleakleyMcD opened this issue Jan 28, 2024 · 5 comments

Comments

@BleakleyMcD
Copy link
Collaborator

BleakleyMcD commented Jan 28, 2024

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈ python JPC_AV/process_file.py /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv
2024-01-26 11:46:21,402 - config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/config.yaml
2024-01-26 11:46:21,406 - command_config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/command_config.yaml
2024-01-26 11:46:21,413 - The file name 'JPC_AV_01637.mkv' is valid.
2024-01-26 11:46:21,413 - Video ID matches directory name
2024-01-26 11:46:21,414 - Metadata files will be written to /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637
2024-01-26 11:46:21,414 - Using MediaConch policy JPC_AV_NTSC_MKV_2023-11-21.xml
2024-01-26 11:46:21,414 - running command: mediaconch -p /Users/medialab/github/JPC_AV_videoQC-main/config/JPC_AV_NTSC_MKV_2023-11-21.xml "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" -oc /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediaconch_output.csv
2024-01-26 11:46:23,032 - MediaConch policy failed
2024-01-26 11:46:23,033 - running command: exiftool "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_exiftool_output.txt
2024-01-26 11:46:23,148 - running command: mediainfo -f "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediainfo_output.txt
2024-01-26 11:46:23,830 - running command: ffprobe -v error -hide_banner -show_format -show_streams -print_format json "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_ffprobe_output.txt
2024-01-26 11:46:24,174 - Processing complete. Output files saved in the directory: /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637
2024-01-26 11:46:24,175 - All specified fields and values found in the Exiftool output.
2024-01-26 11:46:24,175 - Some specified MediaInfo fields or values are missing or don't match:
2024-01-26 11:46:24,175 - 
       metadata field in General: Title does not exist
 
2024-01-26 11:46:24,175 - 
       metadata field in General: Encoded by does not exist
 
2024-01-26 11:46:24,175 - 
       metadata field in General: Description does not exist
 
2024-01-26 11:46:24,175 - 
       metadata field in General: Encoding settings does not exist
 
2024-01-26 11:46:24,175 - 
       metadata field in General: ORIGINAL MEDIA TYPE does not exist
 
2024-01-26 11:46:24,175 - No 'encoder settings' in ffprobe output
2024-01-26 11:46:24,175 - All specified fields and values found in the ffprobe output.
                                                                                
(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈ 

Could it look something more like this, including grouping and spacing. Bold is green text, italic is red. Everything else can be normal. I liked the turquoise-ish color you chose for normal.

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈ python JPC_AV/process_file.py /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv

Running the following processes and checks on JPC_AV_01637.mkv

2024-01-26 11:46:21

-- config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/config.yaml
-- command_config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/command_config.yaml

-- The file name 'JPC_AV_01637.mkv' is valid.
-- Video ID matches directory name

-- Metadata files will be written to /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637

-- Using MediaConch policy JPC_AV_NTSC_MKV_2023-11-21.xml
-- running command: mediaconch -p /Users/medialab/github/JPC_AV_videoQC-main/config/JPC_AV_NTSC_MKV_2023-11-21.xml "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" -oc /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediaconch_output.csv
-- MediaConch policy failed

-- running command: ffprobe -v error -hide_banner -show_format -show_streams -print_format json "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_ffprobe_output.txt
-- No 'encoder settings' in ffprobe output
-- All specified fields and values found in the ffprobe output.

-- running command: exiftool "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_exiftool_output.txt
-- All specified fields and values found in the Exiftool output.

-- running command: mediainfo -f "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediainfo_output.txt

-- The specified MediaInfo fields or values for embedded metadata are below:

  • metadata field in General: "Title" is empty or does not exist
  • metadata field in General: "Encoded by" is empty or does not exist
  • metadata field in General: "Description" is empty or does not exist
  • metadata field in General: "Encoding settings" is empty or does not exist
  • metadata field in General: "ORIGINAL MEDIA TYPE" is empty or does not exist

-- Please note that these warnings on metadata are just used to help any issues with your file. If they are not relevant at this point in your workflow, just ignore this. Thanks!

-- Processing complete. Output files saved in the directory: /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈

If the metadata fields do have an associated value stored, please have the script say:

  • metadata field in General: "Title" has a value of "$VALUE"
@eddycolloton
Copy link
Collaborator

Made some good progress on this: d41d638

Still need to work on sorting conflicting actual/expected values output. For now it is still the old format:
Some specified [metadata tool] fields or values are missing or don't match:

[name of field]
Expected: [value]
Actual: [value]

I'll work on getting it down to 1 line, just needs to be disentangled a bit.

All other requested changes to output have been made with the exception of "--" prefix. It's a little tricky to add this as the code is written, I'll explore options.

@BleakleyMcD
Copy link
Collaborator Author

BleakleyMcD commented Jan 28, 2024 via email

@eddycolloton
Copy link
Collaborator

Output for conflicting actual/expected values is cleaned up: 50e46c2
I had been aggregating the differences in a CSV, but the CSV was parsed based on the old syntax. The differences are aways saved to the log file as well, so the CSV is just a user friendly addition. I'll add the CSV back in once I've sorted out how to do it independent of the phrasing.

@eddycolloton
Copy link
Collaborator

ffmpeg stream progress is now printed to the terminal as a percentage, and mediaconch policy rule fails are also printed to the terminal: 9e1e43c

@eddycolloton
Copy link
Collaborator

eddycolloton commented Aug 9, 2024

@BleakleyMcD As of this commit I've finally gone through and revamped all of the new line characters to make spacing more uniform, and coded consistently. Changed some fonts too. Take a look when you can and if you approve I'll close out this issue: 517fcd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants