feature: 게임방 목록 조회 로직 수정 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- createdAt 칼럼 추가
- filter 날짜 로직 추가
LJH098
requested changes
Nov 3, 2024
Comment on lines
33
to
34
| .filter(workspace -> workspace.getCreatedAt().isBefore(dateFilter)) //게임방 조회: 유지 시간은 24h | ||
| .map(workspace ->GetWorkspacesResponse.of(workspace.getId(), workspace.getCreator().getUid())) |
There was a problem hiding this comment.
isBefore가 아닌 isAfter가 되야 할 것 같아요
dateFilter를 현재부터 하루 전으로 잡았는데 workSpace 생성 시간이 dateFilter보다 작다라는건 만들어진지 하루가 지났다는 뜻이라서 본래의 의도와 정반대가 되는 것 같습니다
|
Conflict 해결해주시고 리뷰 반영하시면 될 것 같아요!! |
Merged
LJH098
force-pushed
the
develop
branch
3 times, most recently
from
e657b04
to
c2e417d
Compare
- isBefore -> isAfter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 게임방 조회파트 등록된 게임은 하루동안 유지되도록 로직 수정
📷 스크린샷(선택)
💬 리뷰 요구사항