Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package versions and the future of the repository #20

Open
LucIJspeert opened this issue Dec 3, 2019 · 3 comments
Open

Package versions and the future of the repository #20

LucIJspeert opened this issue Dec 3, 2019 · 3 comments

Comments

@LucIJspeert
Copy link

Hi,

I'm very new to the IvS Python repository, which is why I wanted to ask what the general consensus is about changing/maintaining/adding code. Especially with regard to use of old and new packages, as astropy is now at version 3.2, matplotlib at 3.1, numpy at 1.17 and scipy at 1.3, to name a few.

I like to develop in up-to-date versions of packages (or at least only some minor updates away from it), to make the best use of functionality and refinements (and more reasons). Of course, I am fully aware that many functions would stop working if all the packages are just updated. To not put the master branch 'at risk' perhaps it would be an idea to create a separate branch named something like 'development' or 'experimental'? This branch could just be associated with updated versions of the required packages and if code is found to be broken with the new packages it can then be fixed and pushed to that branch without breaking the code for users of the original version with the older packages.

To give an example of what I mean: I found some matplotlib 2.0 dependency (to do with recarrays) that has since been moved to numpy, and I really wanted to continue using matplotlib 3+. so I replaced the functions with their numpy equivalents, only to find out that these would only work for numpy 1.15 and up.

So, how to handle these things? I hope to hear your thoughts,

Luc

@ilknurege
Copy link

Hi,

I am using ivs repository to make SED. I updated my ivs folder. But I want to add a new filter. VISTA/VHS filters are not included in the software, anyone can help me to add these filters?

Thank you very much in advance,
cheers,
Ilknur

@LucIJspeert
Copy link
Author

LucIJspeert commented May 26, 2020

Hi Ilknur,

I have moved your question to a separate Issue, as it is not on the topic of this issue page. Please use this new issue page Issue 22 for further conversation on your question. Unfortunately I cannot help you with the issue myself.

@karandis
Copy link
Collaborator

Hi Luc, regarding the development and maintenance of the packages, we need to go through some of the older functions to make sure any deprecated functions still work (and find the replacements, as you did in one of the previous issues). I will ask Rik to add you as a developer of the repository, so we can directly work together on this!

Cheers,
Karan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants