From eb53ff474eaf374cfc143aa7925ec1c9ee7388ba Mon Sep 17 00:00:00 2001
From: Rosie Le Faive <lefaive@gmail.com>
Date: Fri, 22 Jul 2022 10:35:23 -0300
Subject: [PATCH] revert setting up chromedriver.

---
 .github/workflows/build-2.x.yml | 14 +++-----------
 phpunit.xml                     |  2 +-
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/build-2.x.yml b/.github/workflows/build-2.x.yml
index ab6a4b071..439395b0a 100644
--- a/.github/workflows/build-2.x.yml
+++ b/.github/workflows/build-2.x.yml
@@ -23,11 +23,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ["7.4", "8.0"]
         # PHP 8.1 fails - see https://github.com/Islandora/islandora/issues/887
+        php-versions: ["7.4", "8.0"]
+        # test-suite functional-javascript will appear to pass but will skip tests; missing chromedriver.
         test-suite: ["kernel", "functional", "functional-javascript"]
-        drupal-version: ["9.3.x", "9.4.x", "9.5.x-dev"]
         # Not yet Drupal 10 ready - see https://github.com/Islandora/islandora/issues/888
+        drupal-version: ["9.3.x", "9.4.x", "9.5.x-dev"]
         mysql: ["8.0"]
         allowed_failure: [false]
 
@@ -118,15 +119,6 @@ jobs:
       - name: Test scripts
         run: $SCRIPT_DIR/travis_scripts.sh
 
-        # needed for FunctionalJavascript
-      - name: Setup chromedriver
-        uses: nanasess/setup-chromedriver@v1
-
-      - name: Start chromedriver
-        run: |
-          export DISPLAY=:99
-          chromedriver --port=4444 --no-sandbox --url-base=/wd/hub &
-
       - name: PHPUNIT tests
         run: |
           cd $DRUPAL_DIR/web/core
diff --git a/phpunit.xml b/phpunit.xml
index 3e6e1562b..a40917813 100644
--- a/phpunit.xml
+++ b/phpunit.xml
@@ -47,7 +47,7 @@
     <!-- Example for changing the driver args to phantomjs tests MINK_DRIVER_ARGS_PHANTOMJS value: '["http://127.0.0.1:8510"]' -->
     <env name="MINK_DRIVER_ARGS_PHANTOMJS" value=""/>
     <!-- Example for changing the driver args to webdriver tests MINK_DRIVER_ARGS_WEBDRIVER value: '["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]' For using the Firefox browser, replace "chrome" with "firefox" -->
-    <env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]'/>
+    <env name="MINK_DRIVER_ARGS_WEBDRIVER" value=""/>
   </php>
   <testsuites>
     <testsuite name="unit">