From da47bcfb081fc9f42fa547de124431c375a3f76c Mon Sep 17 00:00:00 2001
From: Akanksha Singh <akankshasingh.viet@gmail.com>
Date: Thu, 16 May 2024 12:46:26 -0300
Subject: [PATCH] Node has Parent context does not explicitly check if the
 field exists. (#1019)

* Check that the field exists on node

* Early exit with disabled check
---
 src/IslandoraContextManager.php        | 2 +-
 src/Plugin/Condition/NodeHasParent.php | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/IslandoraContextManager.php b/src/IslandoraContextManager.php
index 9fd93fbc2..ed6f74af9 100644
--- a/src/IslandoraContextManager.php
+++ b/src/IslandoraContextManager.php
@@ -37,7 +37,7 @@ public function evaluateContexts(array $provided = []) {
     }
     /** @var \Drupal\context\ContextInterface $context */
     foreach ($this->getContexts() as $context) {
-      if ($this->evaluateContextConditions($context, $provided) && !$context->disabled()) {
+      if (!$context->disabled() && $this->evaluateContextConditions($context, $provided)) {
         $this->activeContexts[$context->id()] = $context;
       }
     }
diff --git a/src/Plugin/Condition/NodeHasParent.php b/src/Plugin/Condition/NodeHasParent.php
index f9ef0cbf5..813fd00b1 100644
--- a/src/Plugin/Condition/NodeHasParent.php
+++ b/src/Plugin/Condition/NodeHasParent.php
@@ -137,9 +137,11 @@ public function evaluate() {
    *   TRUE if entity references the specified parent.
    */
   protected function evaluateEntity(EntityInterface $entity) {
+    $parent_reference_field = $this->configuration['parent_reference_field'];
     foreach ($entity->referencedEntities() as $referenced_entity) {
-      if ($entity->getEntityTypeID() == 'node' && $referenced_entity->getEntityTypeId() == 'node') {
-        $parent_reference_field = $this->configuration['parent_reference_field'];
+      // Check whether the entity and the referenced entity are nodes.
+      // Also make sure that the field exists.
+      if ($entity->getEntityTypeID() == 'node' && $entity->hasField($parent_reference_field) && $referenced_entity->getEntityTypeId() == 'node') {
         $field = $entity->get($parent_reference_field);
         if (!$field->isEmpty()) {
           $nids = $field->getValue();