Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to set CORS with a .env variable would be nice #333

Closed
noahwsmith opened this issue May 13, 2024 · 2 comments
Closed

Being able to set CORS with a .env variable would be nice #333

noahwsmith opened this issue May 13, 2024 · 2 comments

Comments

@noahwsmith
Copy link
Contributor

To support inter-institutional collaboration, sometimes setting non-default values for CORS is necessary. Currently to do this requires bindmounting a copy of https://github.com/Islandora-Devops/isle-buildkit/blob/main/drupal/rootfs/etc/confd/templates/drupal.fpm.conf.tmpl and inserting into that template.

I believe that this is enough of a "standard use case" that we should support it with a .env variable. I will issue a PR momentarily to address this.

@noahwsmith
Copy link
Contributor Author

What I've done is the VERY SIMPLE version that lets you set a single domain, or *. We could also look at a more complex situation where you pass in a regex that sets a list of allowed domains since you cannot just give it a list in string format. For example: kubernetes/ingress-nginx#5496

@noahwsmith
Copy link
Contributor Author

See comment in #334 for alternate solution inside of Drupal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant