Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks around kill #5

Open
cjyar opened this issue Jun 5, 2023 · 0 comments
Open

Add checks around kill #5

cjyar opened this issue Jun 5, 2023 · 0 comments

Comments

@cjyar
Copy link
Contributor

cjyar commented Jun 5, 2023

If the program is configured to use kill to signal the sidecars to exit, then it should do some checks.

  • On startup, it should check to see if it has shareProcessNamespace. It could try to check for compatible UIDs between its container and the sidecars, but it would be difficult or impossible to cover all the cases.
  • It should ensure that hostPID isn't set. If this Pod started trying to kill all the processes on the node, bad things would happen.

Or, maybe we'll decide that kill is a bad idea and remove the associated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant