Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bogus typings #52

Closed
paul-marechal opened this issue Nov 14, 2019 · 3 comments · Fixed by #60
Closed

Bogus typings #52

paul-marechal opened this issue Nov 14, 2019 · 3 comments · Fixed by #60

Comments

@paul-marechal
Copy link

06527e4#diff-0e3ac3694919aca1db302bc3ebe669f2R34

export default should be export = , according to the way your package is actually behaving.

export default makes TypeScript think that there is a default property like exports.default = , which is not the case.
@paul-marechal paul-marechal mentioned this issue Nov 14, 2019
Merged
1 task
@cdeutsch
Copy link

Related to #50 which recently changed the typings.

@IonicaBizau
Copy link
Owner

Feel free to contribute... I am not very good in how typings work.

@RDIL RDIL mentioned this issue Nov 5, 2020
Merged
@RDIL
Copy link
Contributor

RDIL commented Nov 11, 2020

@IonicaBizau I opened #60 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TypeScript typings
4 participants
@cdeutsch @IonicaBizau @paul-marechal @RDIL