Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryHF code is excessively verbose #1318

Closed
jasagredo opened this issue Nov 21, 2024 · 1 comment
Closed

QueryHF code is excessively verbose #1318

jasagredo opened this issue Nov 21, 2024 · 1 comment
Labels

Comments

@jasagredo
Copy link
Contributor

jasagredo commented Nov 21, 2024

          All of these function definitions seem excessively verbose.

Perhaps even just factoring out a reusable combinator for the Byron-versus-Shelley split would reduce the noise by approximately 2.5x?

Originally posted by @nfrisby in #1267 (comment)

As @amesgen also suggested, we could use some TH helper. Same applies to Cardano/Ledger.hs instances.

Let's do this after the merge.

@jasagredo
Copy link
Contributor Author

This was sufficiently implemented in #1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant