From a36fd875dd1c7068cff4e4a39bcbdc11d9fdd1be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20=E2=80=9CNiols=E2=80=9D=20Jeannerod?= Date: Thu, 19 Dec 2024 18:16:36 +0100 Subject: [PATCH] Enrich comment about disabled `mustReplyTimeout` Co-authored-by: Nicolas Frisby --- .../Test/Consensus/Genesis/Setup/GenChains.hs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs b/ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs index 8a3eda8da4..e6ec79b721 100644 --- a/ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs +++ b/ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs @@ -188,6 +188,12 @@ chainSyncTimeouts = -- chains are finite, and therefore an honest peer can only serve it all, -- then send 'MsgAwaitReply' (therefore entering 'StMustReply'), and then -- stall forever, and it must not be killed for it. + -- + -- Note that this allows the adversaries to stall us forever in that same + -- situation. However, that peer is only allowed to send 'MsgAwaitReply' + -- when they have served their tip, which leaves them fully vulnerable to + -- the Genesis Density Disconnection (GDD) logic. A bug related to this + -- disabled timeout is in fact either a bug in the GDD or in the tests. mustReplyTimeout :: Maybe DiffTime mustReplyTimeout = Nothing