New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewable timer doesn't stop when element goes out of view #13

Open

serbel opened this issue Nov 28, 2017 · 1 comment

Assignees

serbel commented Nov 28, 2017

Timer doesn't stop when measured element goes out of view, so MRC is counted when element is not visible.

Screencast of the problem on video (example from the IAB repository): https://app.box.com/s/l4bbn5svfyo2byu2o1nswtq3dq7tpdoh
Preview (example from the IAB repository): http://clients.weborama.nl/files/campaigns2/7533472420/159726/index.html
Screencast of the problem on the banner (the last test also shows that the visibility timer constantly stops): https://app.box.com/s/u897trberzhm3753l5n7funmpuyct1qv
Preview (banner 300x250): http://clients.weborama.nl/files/campaigns2/6383134786/159606/RU_avito.ru_article_201502_index.html

jdreetz self-assigned this

Contributor

jdreetz commented Jan 22, 2018

The InViewTimer was being re-instantiated without checking that the previous timer had been deleted. This PR fixes the issue - #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment