allow mixing inclusive [] and exclusive {} endpoints in range expression #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return ExpressionInterface | ||
| */ | ||
| public function range($start = null, $end = null, $inclusive = true) | ||
| public function range($start = null, $end = null, $inclusiveFrom = true, $inclusiveTo = false) |
There was a problem hiding this comment.
Shouldn't it be $inclusiveTo = true not to break current $inclusive = true behaviour?
speto
force-pushed
the
master
branch
4 times, most recently
from
228e815 to
ad13ed7
Compare
so expressions like “date:[NOW/DAY-1DAY TO NOW/DAY+1DAY}” are possible http://lucidworks.com/blog/date-math-now-and-filter-queries/
|
@egils Thanks for response, I fixed it and also edit appropriate tests so now CI pass as well. In case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so expressions like “date:[NOW/DAY-1DAY TO NOW/DAY+1DAY}” are possible, more about on http://lucidworks.com/blog/date-math-now-and-filter-queries/