Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new company overview #710

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Switch to the new company overview #710

merged 2 commits into from
Feb 7, 2023

Conversation

Nierot
Copy link
Member

@Nierot Nierot commented Jan 9, 2023

Please add the following information to your pull request:

Please describe what your PR is fixing
In short, this PR has been open in the private repository for a while, since it was stuck behind the commissioner of external affairs. I've discussed this with the current external, and he would like this page to be live instead of the old list page, since companies have complained about the alphabetical order.

Concretely, which issues does your PR solve? (Please reference them by typing Fixes/References Inter-Actief/amelie#<issue_id>)
Fixes #289 and more specifically PR 507 in amelie-private

Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no

Does your PR include any django migrations?
no

Does your PR include the proper translations (did you add translations for new/modified strings)?
no, my PR does not include translations

Does your PR include CSS changes (and did you run the compile_css.sh script in the scripts directory to regenerate the compiled.css file)?
no, my PR does not include CSS changes

Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no

Did you properly test your PR before submitting it?
yes

@bramvandartel
Copy link
Member

Please first make sure that the officer of external affairs updates the 'short description' of all current companies. See /companies/overview

…new overview pages, switching the URLs as well.
Copy link
Member

@Kurocon Kurocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but only merge when we get the OK from the external affairs that all company short descriptions are filled in!

@Nierot
Copy link
Member Author

Nierot commented Feb 7, 2023

I got an ack from the external affairs. This can be merged!

@Kurocon Kurocon merged commit 3a307f4 into main Feb 7, 2023
@Kurocon Kurocon deleted the 289-company-corner branch February 7, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp company corner
3 participants