Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 small errors to compile on MSVC 2017 #111

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Florent2305
Copy link
Contributor

All is in the title :)

@Florent2305 Florent2305 requested review from ecaruyer and astamm March 25, 2024 10:40
@Florent2305 Florent2305 self-assigned this Mar 25, 2024
Copy link
Contributor

@astamm astamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. All good for me. When should we include ANIMA***_EXPORT macro in class definitions?

@Florent2305
Copy link
Contributor Author

Florent2305 commented Mar 25, 2024

Export definitions apply to compiled symbols (in the classic C/C++ compilation pipeline).

By definition, templates do not generate compiled symbols.
It's only when the template instantiation (not the template itself) is compiled will it generate compiled symbols.

In summarize:

  • No export definitions for templates
  • Export definitions for symboles you want to access throw a DLL (symbols: class, variables, function template instaciation)

@ecaruyer
Copy link
Contributor

All good, thanks @Florent2305 !

@ecaruyer ecaruyer merged commit 185203f into Inria-Empenn:master Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants