feat(backoffice): restrict rename & retire

Informatievlaanderen · Oct 4, 2024 · dc839e2 · dc839e2
1 parent e2cf1c2
commit dc839e2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Remove.cs b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Remove.cs
@@ -12,7 +12,6 @@ namespace StreetNameRegistry.Api.BackOffice
     using Microsoft.AspNetCore.Http;
     using Microsoft.AspNetCore.Mvc;
     using Municipality;
-    using Municipality.Exceptions;
     using Swashbuckle.AspNetCore.Filters;
     using System.Threading;
     using System.Threading.Tasks;

diff --git a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Rename.cs b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Rename.cs
@@ -42,6 +42,7 @@ public partial class StreetNameController
         [SwaggerResponseExample(StatusCodes.Status412PreconditionFailed, typeof(PreconditionFailedResponseExamples))]
         [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))]
         [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.DecentraleBijwerker)]
+        [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.InterneBijwerker)]
         public async Task<IActionResult> Rename(
             [FromServices] IIfMatchHeaderValidator ifMatchHeaderValidator,
             [FromServices] IValidator<RenameStreetNameRequest> validator,

diff --git a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Retire.cs b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Retire.cs
@@ -12,7 +12,6 @@ namespace StreetNameRegistry.Api.BackOffice
     using Microsoft.AspNetCore.Http;
     using Microsoft.AspNetCore.Mvc;
     using Municipality;
-    using Municipality.Exceptions;
     using Swashbuckle.AspNetCore.Filters;
     using System.Threading;
     using System.Threading.Tasks;
@@ -39,6 +38,7 @@ public partial class StreetNameController
         [SwaggerResponseExample(StatusCodes.Status412PreconditionFailed, typeof(PreconditionFailedResponseExamples))]
         [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))]
         [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.DecentraleBijwerker)]
+        [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.InterneBijwerker)]
         public async Task<IActionResult> Retire(
             [FromServices] IIfMatchHeaderValidator ifMatchHeaderValidator,
             [FromRoute] RetireStreetNameRequest request,

diff --git a/test/StreetNameRegistry.Api.BackOffice.IntegrationTests/IntegrationTests.cs b/test/StreetNameRegistry.Api.BackOffice.IntegrationTests/IntegrationTests.cs
@@ -26,8 +26,8 @@ public IntegrationTests(IntegrationTestFixture fixture)
         [InlineData("/v2/straatnamen/1/acties/corrigeren/homoniemtoevoeging", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]
         [InlineData("/v2/straatnamen/1/acties/afkeuren", Scopes.DvArAdresBeheer)]
         [InlineData("/v2/straatnamen/1/acties/corrigeren/afkeuring", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]
-        [InlineData("/v2/straatnamen/1/acties/opheffen", Scopes.DvArAdresBeheer)]
-        [InlineData("/v2/straatnamen/1/acties/hernoemen", Scopes.DvArAdresBeheer)]
+        [InlineData("/v2/straatnamen/1/acties/opheffen", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]
+        [InlineData("/v2/straatnamen/1/acties/hernoemen", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]
         [InlineData("/v2/straatnamen/1/acties/corrigeren/opheffing", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]
         [InlineData("/v2/straatnamen/1/acties/corrigeren/straatnaam", Scopes.DvArAdresBeheer)]
         [InlineData("/v2/straatnamen/1/acties/wijzigen/straatnaam", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]