From b671852a70521ab2b720e637393e8bfb6d882de8 Mon Sep 17 00:00:00 2001 From: Arne Dumarey Date: Fri, 4 Oct 2024 08:33:13 +0200 Subject: [PATCH] feat(backoffice): restrict rename & retire --- .../StreetNameController-Remove.cs | 1 - .../StreetNameController-Rename.cs | 1 + .../StreetNameController-Retire.cs | 2 +- .../IntegrationTests.cs | 4 ++-- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Remove.cs b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Remove.cs index edbefadb8..065dda48b 100644 --- a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Remove.cs +++ b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Remove.cs @@ -12,7 +12,6 @@ namespace StreetNameRegistry.Api.BackOffice using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Mvc; using Municipality; - using Municipality.Exceptions; using Swashbuckle.AspNetCore.Filters; using System.Threading; using System.Threading.Tasks; diff --git a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Rename.cs b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Rename.cs index 0b56512bd..f64ba3323 100644 --- a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Rename.cs +++ b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Rename.cs @@ -42,6 +42,7 @@ public partial class StreetNameController [SwaggerResponseExample(StatusCodes.Status412PreconditionFailed, typeof(PreconditionFailedResponseExamples))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.DecentraleBijwerker)] + [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.InterneBijwerker)] public async Task Rename( [FromServices] IIfMatchHeaderValidator ifMatchHeaderValidator, [FromServices] IValidator validator, diff --git a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Retire.cs b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Retire.cs index 4726ac262..bd5b4391f 100644 --- a/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Retire.cs +++ b/src/StreetNameRegistry.Api.BackOffice/StreetNameController-Retire.cs @@ -12,7 +12,6 @@ namespace StreetNameRegistry.Api.BackOffice using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Mvc; using Municipality; - using Municipality.Exceptions; using Swashbuckle.AspNetCore.Filters; using System.Threading; using System.Threading.Tasks; @@ -39,6 +38,7 @@ public partial class StreetNameController [SwaggerResponseExample(StatusCodes.Status412PreconditionFailed, typeof(PreconditionFailedResponseExamples))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.DecentraleBijwerker)] + [Authorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme, Policy = PolicyNames.Adres.InterneBijwerker)] public async Task Retire( [FromServices] IIfMatchHeaderValidator ifMatchHeaderValidator, [FromRoute] RetireStreetNameRequest request, diff --git a/test/StreetNameRegistry.Api.BackOffice.IntegrationTests/IntegrationTests.cs b/test/StreetNameRegistry.Api.BackOffice.IntegrationTests/IntegrationTests.cs index 7df6ff0ea..10b06b11d 100644 --- a/test/StreetNameRegistry.Api.BackOffice.IntegrationTests/IntegrationTests.cs +++ b/test/StreetNameRegistry.Api.BackOffice.IntegrationTests/IntegrationTests.cs @@ -26,8 +26,8 @@ public IntegrationTests(IntegrationTestFixture fixture) [InlineData("/v2/straatnamen/1/acties/corrigeren/homoniemtoevoeging", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")] [InlineData("/v2/straatnamen/1/acties/afkeuren", Scopes.DvArAdresBeheer)] [InlineData("/v2/straatnamen/1/acties/corrigeren/afkeuring", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")] - [InlineData("/v2/straatnamen/1/acties/opheffen", Scopes.DvArAdresBeheer)] - [InlineData("/v2/straatnamen/1/acties/hernoemen", Scopes.DvArAdresBeheer)] + [InlineData("/v2/straatnamen/1/acties/opheffen", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")] + [InlineData("/v2/straatnamen/1/acties/hernoemen", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")] [InlineData("/v2/straatnamen/1/acties/corrigeren/opheffing", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")] [InlineData("/v2/straatnamen/1/acties/corrigeren/straatnaam", Scopes.DvArAdresBeheer)] [InlineData("/v2/straatnamen/1/acties/wijzigen/straatnaam", $"{Scopes.DvArAdresBeheer} {Scopes.DvArAdresUitzonderingen}")]