Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The prometheus counter ldio_data_out_total is incremented too early #661

Closed
rorlic opened this issue Jul 5, 2024 · 0 comments · Fixed by #666
Closed

The prometheus counter ldio_data_out_total is incremented too early #661

rorlic opened this issue Jul 5, 2024 · 0 comments · Fixed by #666
Labels
component: ldio Issues related to Linked Data Interactions good first issue Good for newcomers needs triage Issue needs to be evaluated by team
Milestone
LDI 2.9.0

Comments

@rorlic
Copy link
Contributor

rorlic commented Jul 5, 2024

While investigating github issue #660 we noticed that the ldio_data_out_total counters are updated before the output is actually sent. This results in a mismatch of sent vs. received member count is the member cannot be correctly sent/received.

Please increment the counters only after successful delivery of the member to the actual output channel.
@rorlic rorlic added the needs triage Issue needs to be evaluated by team label Jul 5, 2024
@Yalz Yalz added this to VSDS Backlog Jul 5, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in VSDS Backlog Jul 5, 2024
@rorlic rorlic mentioned this issue Jul 5, 2024
Closed
@Yalz Yalz added good first issue Good for newcomers component: ldio Issues related to Linked Data Interactions labels Jul 5, 2024
@Yalz Yalz linked a pull request Jul 23, 2024 that will close this issue
fix: #660: Repository Sink: performance degradation #666
Merged
@Yalz Yalz added this to the LDI 2.9.0 milestone Sep 10, 2024
@Yalz Yalz closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 👀 In review in VSDS Backlog Oct 16, 2024
@Yalz Yalz moved this from 👀 In review to ✅ Done in VSDS Backlog Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ldio Issues related to Linked Data Interactions good first issue Good for newcomers needs triage Issue needs to be evaluated by team
Projects
VSDS Backlog
Archived in project
Milestone
LDI 2.9.0
2 participants
@rorlic @Yalz