Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom headers on HTTP-Out #359

Closed
brechtvdv opened this issue Oct 16, 2023 · 3 comments · Fixed by #365
Closed

Custom headers on HTTP-Out #359

brechtvdv opened this issue Oct 16, 2023 · 3 comments · Fixed by #365
Assignees
Labels
component: ldio Issues related to Linked Data Interactions enhancement New feature or request good first issue Good for newcomers move to JIRA

Comments

@brechtvdv
Copy link

brechtvdv commented Oct 16, 2023

It would be nice to configure custom headers (e.g. API_KEY) on the HTTP-out connector.
This would allow to run LDIO integrations external from Urban Sense.

@brechtvdv brechtvdv added the needs triage Issue needs to be evaluated by team label Oct 16, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in VSDS Backlog Oct 16, 2023
@Yalz Yalz added enhancement New feature or request good first issue Good for newcomers component: ldio Issues related to Linked Data Interactions and removed needs triage Issue needs to be evaluated by team labels Oct 17, 2023
@Tomvbe
Copy link
Contributor

Tomvbe commented Oct 17, 2023

We can resolve this issue by also using the 'request-executor' in this module

@Tomvbe Tomvbe linked a pull request Oct 20, 2023 that will close this issue
@Tomvbe
Copy link
Contributor

Tomvbe commented Oct 20, 2023

@brechtvdv do you only need this for the api key or for other custom headers as well?

I made a small change that makes it possible to add the following config for the api key:

        auth:
          type: API_KEY
          api-key: my-secret
          api-key-header: x-api-key

Other custom headers are not possible yet but we are looking to add that functionality as well

@jeflaenen
Copy link
Contributor

https://vlaamseoverheid.atlassian.net/browse/VSDSPUB-1054 has been logged on the JIRA-backlog to implement custom headers in the http-out connector of LDIO.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 👀 In review in VSDS Backlog Nov 27, 2023
@Yalz Yalz moved this from 👀 In review to ✅ Done in VSDS Backlog Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ldio Issues related to Linked Data Interactions enhancement New feature or request good first issue Good for newcomers move to JIRA
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants