Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you! #1

Open
Gitoffthelawn opened this issue Sep 27, 2017 · 16 comments
Open

Thank you! #1

Gitoffthelawn opened this issue Sep 27, 2017 · 16 comments

Comments

@Gitoffthelawn
Copy link
Contributor

Thank you for working on this! :)

I'm trying to understand the README. Given the technology available in FF57 (now in Beta channel), is basic functionality possible?

@Infocatcher
Copy link
Owner

Basic functionality is already implemented, so it's possible to open regular links from content pages in new tabs. But currently hardcoded opening in sibling tab (no API to read user preferences and no easy way to re-implement browser.tabs.insertRelatedAfterCurrent = true behavior).
It's (currently?) impossible to handle non-content things (bookmarks, history items), also doesn't work well with void and dummy links with click handlers (e.g. <a href="#" onclick="return doSomething();">click me</a>). And doesn't work with <canvas> images (due to security restrictions).

@Gitoffthelawn
Copy link
Contributor Author

Thanks so much for the explanation. I'm not seeing the WE version on AMO. Is it in the queue yet?

@vurtomatic
Copy link

Would love to have the basic functionality of right clicking on links on content pages, that's the most used imo. Currently using Tap To Tab but that's a double-click instead of one right click!

@MOFTAD
Copy link

MOFTAD commented Oct 1, 2017

@Gitoffthelawn Download the ZIP file, extract it, run the make batch file, and install the resultant XPI file.

@vurtomatic
Copy link

@MOFTAD Is there a way to run the make batch file on a Mac? Or can someone compile this into an addon?

@Infocatcher
Copy link
Owner

May be make.sh will work on Mac too: 20bd80c

Anyway, this is just a dummy way to create ZIP archive with all source files (with some exceptions like not needed *.md).

@Infocatcher
Copy link
Owner

https://github.com/Infocatcher/Right_Links_WE/releases/tag/0.1a1

@vurtomatic
Copy link

@Infocatcher thanks for the 0.1a1! But Firefox wouldn't let it install, says "this add-on could not be installed because it has not been verified".

@Infocatcher
Copy link
Owner

To try: about:debugging -> Load Temporary Add-on
Or in Nightly still available xpinstall.signatures.required = false (about:config)

@vurtomatic
Copy link

To try: about:debugging -> Load Temporary Add-on

That worked, thank you!

@Infocatcher
Copy link
Owner

Signed beta version:
https://addons.mozilla.org/addon/right-links/versions/0.5b1
Note: changed ID of extension (now the same as old Right Links), so previous WE version should be uninstalled.

@Marcosdw
Copy link

Thank you upgraded this extension for Webextension ;)

@Gitoffthelawn
Copy link
Contributor Author

Gitoffthelawn commented Aug 19, 2018

@Infocatcher The excellent WE version is no longer available on AMO. Do you know what happened? Can you get it back on AMO?

@Infocatcher
Copy link
Owner

The excellent WE version is no longer available on AMO. Do you know what happened? Can you get it back on AMO?

All beta versions were removed from AMO side (were hidden and only author may see them)...
https://blog.mozilla.org/addons/2018/02/28/discontinuing-support-for-beta-versions/
Signed versions available here: https://github.com/Infocatcher/Right_Links_WE/releases
So, I should re-upload some new version to AMO (not user and author-friendly).

@Gitoffthelawn
Copy link
Contributor Author

I agree, that although it's not ideal in many ways, a new version on AMO is the best for the future of your fantastic extension.

@Yaron10
Copy link

Yaron10 commented Jan 22, 2019

Thank you for making Right Links compatible with FF Quantum.
Great work. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants