Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exports DefaultTags from package #59

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: exports DefaultTags from package #59

merged 2 commits into from
Feb 9, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Feb 8, 2024

Closes #

Proposed Changes

While doing exploratory testing of the library, I discovered I could not access defaultTags in my local project.

This changes the naming of defaultTags in WriteOptions to DefaultTags to make the field visible outside of the package.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karel-rehor,

Thank you for your contribution and the work you've put into this PR 👍. It's great to see such valuable enhancements being proposed.

Before we proceed to merge and ship your changes, could you please take a moment to update the CHANGELOG.md? Including a summary of your changes in the changelog is crucial for maintaining transparency and keeping our users informed about what's new or changed.

Once the changelog is updated, we'll be all set to move forward 🚀.

Thank you once again for your contribution!

Best regards

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0178ae8) 83.31% compared to head (3442487) 83.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files          11       11           
  Lines         935      935           
=======================================
  Hits          779      779           
  Misses        128      128           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@karel-rehor karel-rehor merged commit 8ca8c97 into main Feb 9, 2024
12 checks passed
@karel-rehor karel-rehor deleted the fix/defaultTags branch February 9, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants