feat: Batcher.Add made variadic to allow passing of multiple points

InfluxCommunity · Oct 1, 2024 · 5309171 · 5309171
1 parent e115711
commit 5309171
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/influxdb3/batching/batcher.go b/influxdb3/batching/batcher.go
@@ -103,13 +103,13 @@ func NewBatcher(options ...Option) *Batcher {
 	return b
 }
 
-// Add a metric to the batcher and call the given callbacks if any
-func (b *Batcher) Add(p *influxdb3.Point) {
+// Add metric(s) to the batcher and call the given callbacks if any
+func (b *Batcher) Add(p ...*influxdb3.Point) {
 	b.Lock()
 	defer b.Unlock()
 
 	// Add the point
-	b.points = append(b.points, p)
+	b.points = append(b.points, p...)
 
 	// Call callbacks if a new batch is ready
 	if b.isReady() {

diff --git a/influxdb3/batching/batcher_test.go b/influxdb3/batching/batcher_test.go
@@ -79,9 +79,8 @@ func TestReady(t *testing.T) {
 		WithSize(batchSize),
 	)
 
-	for range batchSize {
-		b.Add(&influxdb3.Point{})
-	}
+	points := []*influxdb3.Point{{}, {}, {}, {}, {}}
+	b.Add(points...)
 
 	assert.True(t, b.Ready(), "Batcher should be ready when the batch size is reached")
 }
@@ -115,7 +114,7 @@ func TestPartialEmit(t *testing.T) {
 		}),
 	)
 
-	b.Add(&influxdb3.Point{})
+	b.Add(&influxdb3.Point{}, &influxdb3.Point{})
 	b.Add(&influxdb3.Point{})
 
 	points := b.Emit()