We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When uploading a file with LF line endings (\n), the code fails to parse the files correctly, and removes a character from the end of each meassage.
\n
In server/server/parsing/utils.py, we removed a single character from the end of the line (to compensate for Windows line endings).
server/server/parsing/utils.py
def create_chat_def(chat_file): # ... chat_df['message'] = chat_df['message'].str[:-1].astype(str) # remove end of line (could be "/n" or "/t") #...
We should implement a fix that detects if the file uses CRLF or LF line endings, and splits by the corresponding character.
The text was updated successfully, but these errors were encountered:
close #52 issue is handled by strip of the messages
03d5685
this commit is not the changed that solved the problem - only cleaning the code
Fixed in #66, still awaiting review by @InbarShirizly
Sorry, something went wrong.
jonohayon
Successfully merging a pull request may close this issue.
Issue:
When uploading a file with LF line endings (
\n
), the code fails to parse the files correctly, and removes a character from the end of each meassage.Cause:
In
server/server/parsing/utils.py
, we removed a single character from the end of the line (to compensate for Windows line endings).Suggested solution
We should implement a fix that detects if the file uses CRLF or LF line endings, and splits by the corresponding character.
The text was updated successfully, but these errors were encountered: