Registry Instruction #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecchendev
reviewed
Apr 3, 2022
program/src/processor/registry.rs
Outdated
Comment on lines
112
to
144
| let existing_lamports = registry_ai.lamports(); | ||
| **registry_ai.lamports.borrow_mut() = 0; | ||
|
|
||
| //increment registry count and change seeds | ||
| registry_count += 1; | ||
| let registry_seeds = &[ | ||
| b"subscription_registry", | ||
| ®istry_count.to_le_bytes(), | ||
| ] | ||
|
|
||
| //create new registry account with more space for data | ||
| invoke_signed( | ||
| let new_length = registry_length + 48; | ||
| &system_instruction::create_account( | ||
| user_ai.key, | ||
| registry_ai.key, | ||
| rent::Rent::get()?.minimum_balance(new_length - registry_length), | ||
| new_length as u64, | ||
| program_id, | ||
| ), | ||
| &[ | ||
| user_ai.clone(); | ||
| registry_ai.clone(); | ||
| system_program_ai.clone(); | ||
| ], | ||
| &[registry_seeds], | ||
| ); | ||
|
|
||
| //add the lamports from before adding this space | ||
| let user_added_lamports = registry_ai.lamports(); | ||
| **registry_ai.lamports.borrow_mut() = user_added_lamports | ||
| .checked_add(existing_lamports) | ||
| .ok_or(TokenError::Overflow)?; |
There was a problem hiding this comment.
Two main things:
- Another account - you will actually need to pass in another account (where the seeds are "subscription_registry" and registry_count + 1 as you've correctly defined) - your current code works for the very first initialization, but if you are going from an existing registry and adding a new entry, you cannot just recreate the account with more space which you're doing here, you'll have to initialize a new account with more space
- Transferring lamports - your logic right now is technically correct but it's kinda wonky lol - you alr know
system_instruction::create_accountprovides a certain amount of SOL, so I would recommend transferring the lamports from the current to new registry account first, and then callingsystem_instruction::create_accountto fill in the rest
alecchendev
requested changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on creating a registry:
When a user calls the instruction:
To Do: