Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads: In media module deleted files assigned to downloads #879

Open
blackcoder87 opened this issue Nov 26, 2023 · 0 comments
Open

Downloads: In media module deleted files assigned to downloads #879

blackcoder87 opened this issue Nov 26, 2023 · 0 comments
Labels
Type: Bug The issue documents broken, incorrect, or confusing behavior.

Comments

@blackcoder87
Copy link
Member

Describe the bug
When creating a download you upload a file and then choose it or just choose it from the dialog. This uses the media module.
You can delete files from within the media module. The deleted file might be still assigned to a download.

Ideally a FKC should be used, but enforcing this now would delete all downloads where the assigned file got deleted in the media module.

The FKC would link these two columns:
https://github.com/IlchCMS/Ilch-2.0/blob/master/application/modules/downloads/config/config.php#L46
https://github.com/IlchCMS/Ilch-2.0/blob/master/application/modules/media/config/config.php#L43

Add an FKC or keep it as is?

To Reproduce
Steps to reproduce the behavior:

  1. Go to the downloads module and create a new download.
  2. Go to the medial module and delete the file you chose for the download.
  3. Currently it shows that the download is not existing and previously we had an error here.

Expected behavior
Either this should be entirely impossible (FKC) or the current state.

Additional context
#878

@blackcoder87 blackcoder87 added the Type: Bug The issue documents broken, incorrect, or confusing behavior. label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue documents broken, incorrect, or confusing behavior.
Projects
None yet
Development

No branches or pull requests

1 participant