-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts version out of date #4
Comments
CodeContracts 1.9.10714.2 is the latest release. This is what in my nuget package. |
No, you are right, my mistake. However, a recent prerelease would be nice as there are some fixes since last stable release. |
Yes, please update the binaries to 1.10RC! These are the latest working with Roslyn compiled C# 6. There were multiple fixes done by the project members, and I am hitting the issue (microsoft/CodeContracts#169) that has been fixed more than 2 years ago (microsoft/CodeContracts#276). Release 1.10 is unlikely, unfortunately. The tools break with C# 7 so badly that there no fix, barring a complete rewrite. Something like https://github.com/AArnott/CodeGeneration.Roslyn may be the future replacement. |
I will create a prerelease version with updated binaries. Give me a couple days. |
Sure, thank you very much for your work! Спасибо Вам, Игорь! If you do not mind a suggestion, I believe the version should not label the package as a pre-release. If you follow the counts on NuGet, the package install count is in tens of thousands already. Contracts are in the state of winding down, and your work helps so many people out there. I believe it should be made a visible as possible. Making a prerelease would limit its visibility. How many people will just drop it on the floor discovering that the packaged version simply does not work (see this: microsoft/CodeContracts#493)? On the other hand, there will not be a release 1.10; 1.10RC is most likely the last version ever. I have followed the original project since its becoming open-source. It has never achieved a production status, and went to GitHub right from Microsoft Research. There was some development, but the tremendously complex algorithmic core of Contracts was actually never fully taken over. It's just too big not to require one's full dedication, and requires quite strong a background in theoretical CS so as to limit the pool of possible owners. How much may I lament it, in its current form it's essentially over. Your package has been suggested as a way to get contracts working with VS2017 in many places. But I am sure that there are people out there who would just find an use it, and versioning it as a release will save quite a few troubles to people struggling meanwhile while trying to find an alternative for the Contracts. |
Don't bother tagging me, I can't do anything about it. |
Version 1.11-alpha has been released. |
Fantastic, thank you! I'll give it a try tomorrow AM.
On 2 Dec 2017 5:24 p.m., Igor Oleinikov <[email protected]> wrote:
Version 1.11-alpha<https://github.com/Igorbek/CodeContracts.MSBuild/releases/tag/1.11.0-alpha> has been released.
It will be promoted to 1.11 after 2 weeks if it works well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH2NhV1wQ9EZw19mQSSWwHXjAzTcTQK1ks5s8fg0gaJpZM4LZt-b>.
|
Thank you, the tools worked on a few projects I tested! There's a minor issue, the built contract assemblies are not registered as project outputs, and aren't therefore packaged by the Pack target. This is expected, since the original scripts pre-date MSBuild NuGet integration. I'll send you a small PR with the fix. |
Hi Igor, so it seems fixing the packaging issue is blocked on NuGet. I do not have much time to work on that now, have a lot of debt to other OSS projects besides my job. Do you think it's time to release what we have now as 11.1 no alpha? Accepting the refactoring request #13 is up to you. It is only a refactoring, in preparation for the future NuGet fix, no functional changes there, just tidying up stuff. The addition of default .props is not in the published 11.1-alpha. We would certainly benefit from it, thanks! |
Hey @kkm000, sorry for the delay. I was also super busy with other stuff. |
|
Hey Igor,
maybe you could update your nuget package to the latest code contracts version?
The text was updated successfully, but these errors were encountered: