Add generic sample tests and test generation. #823
Conversation
skrustev
requested review from
damyanpetev and
turbobobbytraykov
and removed request for
dkamburov
skrustev
force-pushed
the
skrastev/playwright-tests
branch
from
9941850 to
4cf28c6
Compare
| @@ -0,0 +1,75 @@ | |||
| This documents provides instruction on building and running Samples Browser Tests | |||
There was a problem hiding this comment.
For the Client samples only; is it applicable for the Server ones as well?
There was a problem hiding this comment.
Both samples are pretty much the same, this is more implementation details which one can see when he/she opens the solution?
| - Instal Blazor **.NET SDK** from this website: | ||
| https://dotnet.microsoft.com/learn/aspnet/blazor-tutorial/install | ||
|
|
||
| - If you don't have pwsh, you will have to [install Powershell](https://docs.microsoft.com/powershell/scripting/install/installing-powershell) |
There was a problem hiding this comment.
Is this mandatory? Can the regular Windows Powershell be used?
There was a problem hiding this comment.
Assuming it's for the playwright.ps1 install command below and I can confirm the default works just fine:
This is how Playwright guide (using pwsh) possibly since it's cross-plat and they can give a single command that works on linux/mac as well. Don't mind noting those are optional (same for Blazor SDK since that's usually bundled with VS, no?)
|
|
||
| - Build the solution. Should successfully build all projects. | ||
|
|
||
| ## 4. Run tests |
There was a problem hiding this comment.
Please add a command line command to run the tests - aligned with the fact that we provide commands for everything else so far - in this readme and the one in the repo root.
|
|
||
| - Build the solution. Should successfully build all projects. | ||
|
|
||
| ## 4. Run tests |
There was a problem hiding this comment.
Also, if running the tests from Visual Studio and/or the command line requires to have an already running Samples Browser app, please mention it as a prerequisite.
There was a problem hiding this comment.
That is not longer needed.
|
|
||
| - Build the solution. Should successfully build all projects. | ||
|
|
||
| ## 4. Run tests |
There was a problem hiding this comment.
.runsettings - should we set a default number of workers or at least mention that running the tests will load the running computer quite a bit?
There was a problem hiding this comment.
There is already that configuration in the runsettings. Playwright using a lot of resources, I don't know atm. Might be issue on either end.
No description provided.