Skip to content
This repository has been archived by the owner on Jun 12, 2021. It is now read-only.

response_info not initialized correctly sometimes #64

Open
angelakis opened this issue Jul 10, 2020 · 1 comment
Open

response_info not initialized correctly sometimes #64

angelakis opened this issue Jul 10, 2020 · 1 comment

Comments

@angelakis
Copy link
Contributor

angelakis commented Jul 10, 2020

In authorization's post_authentication method, there's some error handling before creating response_info and filling the return_uri entry etc., for example here:

response_info, "access_denied", "{}".format(err.args)

The response_info is initialized in line 555 and in 566 the return_uri is filled.

As a result, when do_response is called, there's an exception raised in

resp = _response.request(kwargs["return_uri"], True)

as return_uri is considered to always be there.

We could say that the app using oidcendpoint could fill the return_uri to avoid the error, but I feel it would be better if in post_authentication the response_info was filled at the beginning rather than in the middle of the method.

@peppelinux
Copy link
Member

If we have that value first... Yes, we could Simply fill this at the begin. Have you already done a PR for this or should we try to analyze if there would be some warnings on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants