You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 12, 2021. It is now read-only.
In authorization's post_authentication method, there's some error handling before creating response_info and filling the return_uri entry etc., for example here:
We could say that the app using oidcendpoint could fill the return_uri to avoid the error, but I feel it would be better if in post_authentication the response_info was filled at the beginning rather than in the middle of the method.
The text was updated successfully, but these errors were encountered:
If we have that value first... Yes, we could Simply fill this at the begin. Have you already done a PR for this or should we try to analyze if there would be some warnings on this?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In authorization's
post_authentication
method, there's some error handling before creatingresponse_info
and filling thereturn_uri
entry etc., for example here:oidcendpoint/src/oidcendpoint/oidc/authorization.py
Line 538 in 5929fde
The response_info is initialized in line 555 and in 566 the
return_uri
is filled.As a result, when
do_response
is called, there's an exception raised inoidcendpoint/src/oidcendpoint/endpoint.py
Line 422 in 5929fde
as return_uri is considered to always be there.
We could say that the app using oidcendpoint could fill the return_uri to avoid the error, but I feel it would be better if in
post_authentication
theresponse_info
was filled at the beginning rather than in the middle of the method.The text was updated successfully, but these errors were encountered: